Skip to content

Draft - fix: restart lsp server without shutdown #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Draft - fix: restart lsp server without shutdown #1215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd465e2
fix: restart lsp server without shutdown
sigmaaa May 6, 2025
425d2d1
fix: test if issue happens without our restart
sigmaaa May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bundles/com.espressif.idf.core/src/com/espressif/idf/core/util/LspService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ public LspService(Configuration configuration, List<LanguageServerWrapper> langu

public void restartLspServers()
{
languageServerWrappers.forEach(w ->
// ensures that the LS is initialized before proceeding.
w.execute(ls -> ls.shutdown()).thenRun(w::restart));
// languageServerWrappers.forEach(w ->
// // ensures that the LS is initialized before proceeding.
// w.restart());
}

public void updateAdditionalOptions(String additionalOptions)
Expand Down
Loading