Skip to content

Update README.md new mvn clean command (IEP-1560) #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md new mvn clean command (IEP-1560) #1244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ Please refer to the <a href="https://docs.espressif.com/projects/espressif-ide/e
```
git clone https://github.com/espressif/idf-eclipse-plugin.git
cd idf-eclipse-plugin
mvn clean verify -Djarsigner.skip=true
mvn clean verify -Djarsigner.skip=true \
-Djdk.xml.maxGeneralEntitySizeLimit=0 \
-Djdk.xml.totalEntitySizeLimit=0
Copy link
Collaborator

@kolipakakondal kolipakakondal Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. While this can help bypass errors with large XML files, setting these limits to zero disables important protections against XML. These limits are in place to prevent malicious or accidental resource exhaustion

Best practice is to only increase these limits as much as necessary when needed, not to remove them entirely. If we are hitting the default limits, we should set them to a large but finite value that is sufficient for our use case (e.g., -Djdk.xml.totalEntitySizeLimit=200000000 for 200MB), rather than disabling the limit.

For now, I am not merging this change.

Thanks again for your effort and understanding!

```

This will generate p2 update site artifact:
Expand Down