IEP-1637 Upgrade Eclipse target platform: LSP4E 0.27.10, CDT-LSP 3.3 #1317
Conversation
WalkthroughUpdated the Eclipse target definition and repository tracks: platform/releases/orbit versions and URLs changed, several installable units added/removed (including UI/terminal/logging/xml/gson), lsp4e/tm4e/cdt-lsp versions bumped, and two SWTBot UI tests updated to select "Window" → "Preferences...". Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Test as SWTBot Test
participant UI as Eclipse UI
Note right of Test #E8F5E9: Menu label change to "Preferences..."
Test->>UI: Open "Window" menu
Test->>UI: Click "Preferences..."
UI-->>Test: Open Preferences dialog
alt menu item missing / timeout
UI-->>Test: Error/timeout
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
releng/com.espressif.idf.target/com.espressif.idf.target.target(6 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build_macos
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
releng/com.espressif.idf.target/com.espressif.idf.target.target(6 hunks)
🔇 Additional comments (1)
releng/com.espressif.idf.target/com.espressif.idf.target.target (1)
100-100: CDT-LSP 3.3 repository still missing. As noted previously,https://download.eclipse.org/tools/cdt/releases/cdt-lsp-3.3/cdt-lsp-3.3.0/remains a 404, so upgrading to CDT-LSP 3.3 breaks the target. Please revert to 3.2 (or wait for 3.3 to land).(download.eclipse.org)
releng/com.espressif.idf.target/com.espressif.idf.target.target
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/com.espressif.idf.ui.test/src/com/espressif/idf/ui/test/operations/EnvSetupOperations.java (1)
51-64: Minor: fix typo in variable nameprefrencesShellRename to
preferencesShellfor readability and searchability.- SWTBotShell prefrencesShell = bot.shell("Preferences"); + SWTBotShell preferencesShell = bot.shell("Preferences"); - prefrencesShell.bot().tree().getTreeItem("General").select(); - prefrencesShell.bot().tree().getTreeItem("General").expand(); - prefrencesShell.bot().tree().getTreeItem("General").getNode("Editors").select(); - prefrencesShell.bot().tree().getTreeItem("General").getNode("Editors").expand(); - prefrencesShell.bot().tree().getTreeItem("General").getNode("Editors").getNode("File Associations").select(); - prefrencesShell.bot().comboBox().setSelection("Plain Text Editor"); - prefrencesShell.bot().tree().getTreeItem("General").getNode("Workspace").select(); - if (!prefrencesShell.bot().checkBox("Refresh using native hooks or polling").isChecked()) + preferencesShell.bot().tree().getTreeItem("General").select(); + preferencesShell.bot().tree().getTreeItem("General").expand(); + preferencesShell.bot().tree().getTreeItem("General").getNode("Editors").select(); + preferencesShell.bot().tree().getTreeItem("General").getNode("Editors").expand(); + preferencesShell.bot().tree().getTreeItem("General").getNode("Editors").getNode("File Associations").select(); + preferencesShell.bot().comboBox().setSelection("Plain Text Editor"); + preferencesShell.bot().tree().getTreeItem("General").getNode("Workspace").select(); + if (!preferencesShell.bot().checkBox("Refresh using native hooks or polling").isChecked()) - { - prefrencesShell.bot().checkBox("Refresh using native hooks or polling").click(); - } - prefrencesShell.bot().button("Apply and Close").click(); + { + preferencesShell.bot().checkBox("Refresh using native hooks or polling").click(); + } + preferencesShell.bot().button("Apply and Close").click();
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/com.espressif.idf.ui.test/src/com/espressif/idf/ui/test/operations/EnvSetupOperations.java(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build_windows
- GitHub Check: build
...s/com.espressif.idf.ui.test/src/com/espressif/idf/ui/test/operations/EnvSetupOperations.java
Show resolved
Hide resolved
|
Updated LSP4E to 0.27.10 due to the critical bug for us on 0.27.9. More info: eclipse-lsp4e/lsp4e#1322 |
sigmaaa
changed the title
releng/com.espressif.idf.target/com.espressif.idf.target.target
Outdated
Show resolved
Hide resolved
| <unit id="org.apache.commons.logging" version="0.0.0"/> | ||
| <unit id="javax.xml.jre" version="0.0.0"/> |
There was a problem hiding this comment.
By default these will be included, do you see any specific usecase? if you need a specific version other than the default one for some reason, you can check eclipse orbit
There was a problem hiding this comment.
Hi @kolipakakondal,
Without this, the build fails to compile the org.w3c.dom dependency.
kolipakakondal
left a comment
kolipakakondal
left a comment
There was a problem hiding this comment.
Check PR comments, otherwise LGTM
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
releng/com.espressif.idf.target/com.espressif.idf.target.target (1)
26-32: Remove unnecessary installable unitorg.apache.commons.logging.No references to this unit were found in code or XML; the other units are required.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
releng/com.espressif.idf.target/com.espressif.idf.target.target(6 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build
- GitHub Check: build_macos
- GitHub Check: build_windows
🔇 Additional comments (5)
releng/com.espressif.idf.target/com.espressif.idf.target.target (5)
93-96: TM4E 0.15.1 repository is accessible. Verified HTTP 200 response from https://download.eclipse.org/tm4e/releases/0.15.1/.
6-6: Verified: Eclipse 4.37 repository is accessible (HTTP 200).
84-91: Approve LSP4E 0.27.10 upgrade
Repository is accessible and P2 metadata confirmed; fixes critical bug in 0.27.9 ([lsp4e#1322]).
20-20: SimRel 2025-09 repository confirmed accessible. HTTP 200 indicates https://download.eclipse.org/releases/2025-09/ is now reachable and serving content as expected.
51-51: Verify presence of Batik artifacts in Orbit 2025-09.Run:
URL="https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/2025-09" curl -s "${URL}/" | grep -i batik
|
Hi @AndriiFilippov, since this PR includes dependency updates, we need to verify the basic functionality of the IDE when testing it. |
|
Hi @AndriiFilippov Please verify, we can consider this for v3.7.0 |
|
@sigmaaa @kolipakakondal hi ! Tested under: Syntax Highlighting, auto-completion, go to definition, clangd ✔️ |
Thanks @AndriiFilippov for verifying. |
Description
Please include a summary of the change and which issue is fixed.
Fixes # (IEP-1637)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit
New Features
Chores
Bug Fixes