Skip to content

IEP-1637 Upgrade Eclipse target platform: LSP4E 0.27.10, CDT-LSP 3.3 #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 9, 2025
Merged

IEP-1637 Upgrade Eclipse target platform: LSP4E 0.27.10, CDT-LSP 3.3 #1317

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5e6c650
feat: updating target dependencies
sigmaaa Sep 29, 2025
bb8d687
fix: added missing units to the target
sigmaaa Sep 29, 2025
e4b9143
fix: adding javax.xml.jre to resolve missing w3c
sigmaaa Sep 29, 2025
0ba285b
fix: trying to add some units to fix swtbot tests
sigmaaa Sep 29, 2025
cb60721
fix: new updating new preferences menu name
sigmaaa Sep 29, 2025
5d88c60
fix: updated preference name in other tests
sigmaaa Sep 29, 2025
def6ed8
fix: fixed one more updating name for Preferences menu
sigmaaa Sep 29, 2025
755c4b6
feat: updating lsp4e to 0.27.10
sigmaaa Oct 2, 2025
0878fbf
fix: removing the unused feature group from the target
sigmaaa Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions releng/com.espressif.idf.target/com.espressif.idf.target.target
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@
<target name="com.espressif.idf.target" sequenceNumber="25">
<locations>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<repository location="https://download.eclipse.org/eclipse/updates/4.35"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.37"/>
<unit id="org.eclipse.equinox.sdk.feature.group" version="0.0.0"/>
<unit id="org.eclipse.rcp.feature.group" version="0.0.0"/>
<unit id="org.eclipse.rcp.source.feature.group" version="0.0.0"/>
<unit id="org.eclipse.test.feature.group" version="0.0.0"/>
<unit id="org.eclipse.equinox.p2.core.feature.feature.group" version="0.0.0"/>
<unit id="org.eclipse.equinox.p2.discovery.feature.feature.group" version="0.0.0"/>
Expand All @@ -16,17 +15,22 @@
<unit id="org.eclipse.help.feature.group" version="0.0.0"/>
<unit id="org.eclipse.platform.feature.group" version="0.0.0"/>
<unit id="org.eclipse.pde.feature.group" version="0.0.0"/>

<unit id="org.eclipse.sdk.feature.group" version="0.0.0"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<repository location="https://download.eclipse.org/releases/2025-03/"/>
<repository location="https://download.eclipse.org/releases/2025-09/"/>
<unit id="org.eclipse.cdt.autotools.feature.group" version="0.0.0"/>
<unit id="org.eclipse.cdt.feature.group" version="0.0.0"/>
<unit id="org.eclipse.cdt.sdk.feature.group" version="0.0.0"/>
<unit id="org.eclipse.cdt.cmake.feature.group" version="0.0.0"/>
<unit id="org.eclipse.tm.terminal.control.feature.feature.group" version="0.0.0"/>
<unit id="org.eclipse.tm.terminal.connector.process" version="0.0.0"/>
<unit id="org.eclipse.tm.terminal.feature.feature.group" version="0.0.0"/>
<unit id="org.eclipse.tm.terminal.view.ui" version="0.0.0"/>
<unit id="org.eclipse.tm.terminal.view.feature.feature.group" version="0.0.0"/>
<unit id="org.eclipse.ui" version="0.0.0"/>
<unit id="org.apache.commons.logging" version="0.0.0"/>
<unit id="javax.xml.jre" version="0.0.0"/>
Comment on lines +31 to +32
Copy link
Collaborator

@kolipakakondal kolipakakondal Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default these will be included, do you see any specific usecase? if you need a specific version other than the default one for some reason, you can check eclipse orbit

Copy link
Collaborator Author

@sigmaaa sigmaaa Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kolipakakondal,

Without this, the build fails to compile the org.w3c.dom dependency.

<unit id="org.eclipse.launchbar.feature.group" version="0.0.0"/>
<unit id="org.eclipse.epp.mpc.feature.group" version="0.0.0"/>
</location>
Expand All @@ -45,7 +49,7 @@
<unit id="org.apache.batik.i18n" version="0.0.0"/>
<unit id="org.apache.batik.constants" version="0.0.0"/>
<unit id="org.commonmark" version="0.0.0"/> <!-- 0.22.0 -->
<repository location="https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/2025-03"/>
<repository location="https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/2025-09"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.jgit.feature.group" version="0.0.0"/>
Expand Down Expand Up @@ -78,7 +82,7 @@
<unit id="org.eclipse.embedcdt.packs.feature.group" version="6.4.0.202307251916"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
<repository location="https://download.eclipse.org/lsp4e/releases/0.27.4/"/>
<repository location="https://download.eclipse.org/lsp4e/releases/0.27.10/"/>
<unit id="org.eclipse.lsp4e" version="0.0.0"/>
<unit id="org.eclipse.lsp4e.debug" version="0.0.0"/>
<unit id="org.eclipse.lsp4j" version="0.0.0"/>
Expand All @@ -87,7 +91,7 @@
<unit id="org.eclipse.lsp4j.jsonrpc.debug" version="0.0.0"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
<repository location="https://download.eclipse.org/tm4e/releases/0.14.1/"/>
<repository location="https://download.eclipse.org/tm4e/releases/0.15.1/"/>
<unit id="org.eclipse.tm4e.feature.feature.group" version="0.0.0"/>
<unit id="org.eclipse.tm4e.language_pack.feature.feature.group" version="0.0.0"/>
</location>
Expand All @@ -96,7 +100,7 @@
<unit id="org.eclipse.justj.openjdk.hotspot.jre.full.feature.group" version="0.0.0"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
<repository location="https://download.eclipse.org/tools/cdt/releases/cdt-lsp-3.2/cdt-lsp-3.2.0/"/>
<repository location="https://download.eclipse.org/tools/cdt/releases/cdt-lsp-3.3/cdt-lsp-3.3.0/"/>
<unit id="org.eclipse.cdt.lsp.feature.feature.group" version="0.0.0"/>
<unit id="org.yaml.snakeyaml" version="2.2.0"/>
</location>
Expand Down
4 changes: 2 additions & 2 deletions .../espressif/idf/ui/test/executable/cases/project/NewEspressifIDFProjectClangFilesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ void app_main(void) {

private static void setupAutoSave() throws Exception
{
bot.menu("Window").menu("Preferences").click();
bot.menu("Window").menu("Preferences...").click();
SWTBotShell prefrencesShell = bot.shell("Preferences");
prefrencesShell.bot().tree().getTreeItem("C/C++").select();
prefrencesShell.bot().tree().getTreeItem("C/C++").expand();
Expand Down Expand Up @@ -441,7 +441,7 @@ private static void whenProjectIsBuiltUsingContextMenu(String projectName) throw

private static void whenOpenClangdPreferences() throws Exception
{
bot.menu("Window").menu("Preferences").click();
bot.menu("Window").menu("Preferences...").click();
TestWidgetWaitUtility.waitForDialogToAppear(bot, "Preferences", 10000);
SWTBotShell prefrencesShell = bot.shell("Preferences");
prefrencesShell.bot().tree().getTreeItem("C/C++").select();
Expand Down
2 changes: 1 addition & 1 deletion ...om.espressif.idf.ui.test/src/com/espressif/idf/ui/test/operations/EnvSetupOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public static void setupEspressifEnv(SWTWorkbenchBot bot) throws Exception
bot.table().select("C/C++");
bot.button("Open").click();

bot.menu("Window").menu("Preferences").click();
bot.menu("Window").menu("Preferences...").click();
SWTBotShell prefrencesShell = bot.shell("Preferences");

prefrencesShell.bot().tree().getTreeItem("General").select();
Expand Down
Loading