Skip to content

Conversation

@alirana01
Copy link
Collaborator

@alirana01 alirana01 commented Oct 16, 2025

ci fix for ps regex

Summary by CodeRabbit

  • Chores
    • Improved Windows build verification process with enhanced error reporting and more robust output handling during release verification steps.

@coderabbitai
Copy link

coderabbitai bot commented Oct 16, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Refines the Windows CI release workflow: quotes the keytool alias argument, captures full keytool output as text, validates presence of PrivateKeyEntry by parsing that text, and prints the captured output on failures before throwing.

Changes

Cohort / File(s) Summary
Windows CI release workflow
​.github/workflows/ci_release.yml
Quote -alias as "-alias \"$env:ALIAS\"" in the Windows verification path; capture keytool output into a consolidated text variable (outText), check for PrivateKeyEntry by parsing that text, and print full command output on non-zero exits before throwing errors. Debug excerpt printing retained only for diagnostics.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub as GitHub Actions
    participant PowerShell as Windows runner (PowerShell)
    participant Keytool as keytool
    Note over PowerShell,Keytool #DDEEFF: Windows verification step

    GitHub->>PowerShell: run signing verification step
    PowerShell->>Keytool: invoke keytool -list -keystore ... "-alias \"$env:ALIAS\""
    Keytool-->>PowerShell: command stdout/stderr (captured)
    alt exit code == 0 and outText contains "PrivateKeyEntry"
        PowerShell->>GitHub: mark verification success
    else any failure or no PrivateKeyEntry
        PowerShell->>GitHub: write full captured output to host
        PowerShell->>GitHub: throw error / fail step
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Fixing ci signing for windows #1330: Also modifies the Windows signing/verification workflow and touches keytool/PFX handling; strongly related to alias/output handling changes here.

Suggested reviewers

  • AndriiFilippov
  • kolipakakondal

Poem

"I hopped into CI with a tiny grin,
Quoted my alias and checked within.
I captured the output, loud and clear,
Found my PrivateKey — hoppity cheer!
Builds now prance without a frown." 🐇✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch IEP-1647-upd

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dbb9d38 and 41fad3a.

📒 Files selected for processing (1)
  • .github/workflows/ci_release.yml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alirana01 alirana01 merged commit 8cb4ea9 into master Oct 16, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants