From c2a838e6ddbdc8c6e0641c3dd479492685ecb91c Mon Sep 17 00:00:00 2001
From: Ali Azam Rana <85216275+alirana01@users.noreply.github.com>
Date: Fri, 17 Oct 2025 14:46:47 +0200
Subject: [PATCH] fixing pwsh syntax for signing

---
 .github/workflows/ci_release.yml | 26 +++++++++++++++++---------
 1 file changed, 17 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/ci_release.yml b/.github/workflows/ci_release.yml
index e6fffdf78..f573ba395 100644
--- a/.github/workflows/ci_release.yml
+++ b/.github/workflows/ci_release.yml
@@ -191,15 +191,23 @@ jobs:
       - name: Convert JKS to PFX
         shell: pwsh
         run: |
-          & "${env:JAVA_HOME}\bin\keytool.exe" -importkeystore `
-          -srckeystore "$PWD\signing.jks" `
-          -srcstorepass $env:JKS_PASS `
-          -srcalias $env:ALIAS `
-          -srckeypass $env:JKS_PASS `  
-          -destkeystore "$PWD\cert.pfx" `
-          -deststoretype PKCS12 `
-          -deststorepass $env:PFX_PASS `
-          -destkeypass $env:PFX_PASS
+          if (($env:JKS_PASS).Length -lt 6) { throw "JKS_PASS must be at least 6 characters." }
+          if (($env:PFX_PASS).Length -lt 6) { throw "PFX_PASS must be at least 6 characters." }
+          
+          $kt = Join-Path $env:JAVA_HOME 'bin\keytool.exe'
+
+          $args = @(
+           '-importkeystore',
+           '-srckeystore',  "$PWD\signing.jks",
+           '-srcstorepass', $env:JKS_PASS,
+           '-srcalias',     $env:ALIAS,
+           '-srckeypass',   $env:JKS_PASS, 
+           '-destkeystore', "$PWD\cert.pfx",
+           '-deststoretype','PKCS12',
+           '-deststorepass',$env:PFX_PASS,
+           '-destkeypass',  $env:PFX_PASS
+          )
+          & $kt @args
           if (-not (Test-Path "$PWD\cert.pfx")) { throw "cert.pfx not created" }
 
       - name: Prove PFX has a private key (fail fast)