Skip to content

fixing pwsh syntax for signing #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
+17 −9
Merged

fixing pwsh syntax for signing #1336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions .github/workflows/ci_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,15 +191,23 @@ jobs:
- name: Convert JKS to PFX
shell: pwsh
run: |
& "${env:JAVA_HOME}\bin\keytool.exe" -importkeystore `
-srckeystore "$PWD\signing.jks" `
-srcstorepass $env:JKS_PASS `
-srcalias $env:ALIAS `
-srckeypass $env:JKS_PASS `
-destkeystore "$PWD\cert.pfx" `
-deststoretype PKCS12 `
-deststorepass $env:PFX_PASS `
-destkeypass $env:PFX_PASS
if (($env:JKS_PASS).Length -lt 6) { throw "JKS_PASS must be at least 6 characters." }
if (($env:PFX_PASS).Length -lt 6) { throw "PFX_PASS must be at least 6 characters." }
$kt = Join-Path $env:JAVA_HOME 'bin\keytool.exe'
$args = @(
'-importkeystore',
'-srckeystore', "$PWD\signing.jks",
'-srcstorepass', $env:JKS_PASS,
'-srcalias', $env:ALIAS,
'-srckeypass', $env:JKS_PASS,
'-destkeystore', "$PWD\cert.pfx",
'-deststoretype','PKCS12',
'-deststorepass',$env:PFX_PASS,
'-destkeypass', $env:PFX_PASS
)
& $kt @args
if (-not (Test-Path "$PWD\cert.pfx")) { throw "cert.pfx not created" }
- name: Prove PFX has a private key (fail fast)
Expand Down
Loading