WIP: Welcome Page: corrupted after migration from IDE v3.6.0 to 4.0.0 #1361
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughUpdated the intro page configuration in introcontent.xml to replace hard-coded index.html URLs with proper Eclipse UI intro URLs for the root page and standby page references. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bundles/com.espressif.idf.ui/introcontent.xml (1)
1-9: Complete PR checklist and description before merging.This PR is marked as WIP with an incomplete description (placeholders only) and all checklist items unchecked. Before this can be reviewed and merged:
- Provide a concrete issue link (not IEP-XXX placeholder)
- Document actual testing steps performed (not Test A/B placeholders)
- Verify changes on Windows, Linux, and macOS
- Apply code formatting
- Confirm the corruption issue is resolved with these changes
Please complete the PR checklist and provide:
- Link to the actual issue (IEP-1655 appears to be the ticket)
- Specific steps taken to reproduce and verify the corruption is fixed
- Confirmation that the Welcome Page renders correctly after these changes
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bundles/com.espressif.idf.ui/introcontent.xml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build_macos
- GitHub Check: build
🔇 Additional comments (1)
bundles/com.espressif.idf.ui/introcontent.xml (1)
5-8: Verify Eclipse intro framework URL formats.The root page uses
http://org.eclipse.ui.intro/showPage?id=root, which appears to be an Eclipse intro custom protocol handler. Please confirm these URL formats are correct for your Eclipse version and verify that the resources they reference actually exist and render properly.To validate, verify:
- That the Eclipse intro framework supports these URL formats
- That the root page with id="root" is properly defined elsewhere in the intro configuration
- That the index.html resource exists at the path specified in line 8 (after fixing the plugin ID typo)
| <page | ||
| id="standbyPageId" | ||
| url="index.html"/> | ||
| url="platform:/plugin/com.espessif.idf.ui/index.html"/> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, find and read the introcontent.xml file to verify the actual content
find . -name "introcontent.xml" -type f | head -20Repository: espressif/idf-eclipse-plugin
Length of output: 119
🏁 Script executed:
# Read the introcontent.xml file to check line 8
cat -n ./bundles/com.espressif.idf.ui/introcontent.xml | head -15Repository: espressif/idf-eclipse-plugin
Length of output: 416
🏁 Script executed:
# Read the MANIFEST.MF to confirm the correct plugin ID
cat -n ./bundles/com.espressif.idf.ui/META-INF/MANIFEST.MFRepository: espressif/idf-eclipse-plugin
Length of output: 2773
🏁 Script executed:
# Search for any other instances of the misspelled "espessif" in the codebase
rg "espessif" --type-list | head -5Repository: espressif/idf-eclipse-plugin
Length of output: 461
🏁 Script executed:
# Search for any other instances of the misspelled "espessif" in the codebase
rg "espessif" -nRepository: espressif/idf-eclipse-plugin
Length of output: 187
Plugin ID typo in standbyPageId URL will break resource resolution at runtime.
Line 8 references com.espessif.idf.ui (missing 'r'), but the bundle's symbolic name is com.espressif.idf.ui (as declared in MANIFEST.MF line 4). The platform: protocol requires an exact match to the bundle ID. This mismatch will cause the URL to fail resolution, breaking the standby page.
Fix:
- url="platform:/plugin/com.espessif.idf.ui/index.html"/>
+ url="platform:/plugin/com.espressif.idf.ui/index.html"/>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| url="platform:/plugin/com.espessif.idf.ui/index.html"/> | |
| url="platform:/plugin/com.espressif.idf.ui/index.html"/> |
🤖 Prompt for AI Agents
In bundles/com.espressif.idf.ui/introcontent.xml around line 8, the
standbyPageId URL uses the wrong bundle ID `com.espessif.idf.ui` (typo: missing
'r') which prevents platform:/plugin resolution; update the url attribute to the
correct bundle symbolic name `com.espressif.idf.ui` so the platform:/plugin path
matches the bundle ID declared in MANIFEST.MF and the standby page resource can
be resolved at runtime.
Description
Please include a summary of the change and which issue is fixed.
Fixes # (IEP-XXX)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.