Skip to content

WIP: Welcome Page: corrupted after migration from IDE v3.6.0 to 4.0.0 #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

WIP: Welcome Page: corrupted after migration from IDE v3.6.0 to 4.0.0 #1361

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cabceef
fix: changing the index.html url reference
sigmaaa Nov 28, 2025
9cec086
fix: trying to force always open home page
sigmaaa Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bundles/com.espressif.idf.ui/introcontent.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
<introContent>
<page
id="root"
url="index.html"/>
url="http://org.eclipse.ui.intro/showPage?id=root" />
<page
id="standbyPageId"
url="index.html"/>
url="platform:/plugin/com.espessif.idf.ui/index.html"/>
Copy link

@coderabbitai coderabbitai bot Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

# First, find and read the introcontent.xml file to verify the actual content
find . -name "introcontent.xml" -type f | head -20

Repository: espressif/idf-eclipse-plugin

Length of output: 119

🏁 Script executed:

# Read the introcontent.xml file to check line 8
cat -n ./bundles/com.espressif.idf.ui/introcontent.xml | head -15

Repository: espressif/idf-eclipse-plugin

Length of output: 416

🏁 Script executed:

# Read the MANIFEST.MF to confirm the correct plugin ID
cat -n ./bundles/com.espressif.idf.ui/META-INF/MANIFEST.MF

Repository: espressif/idf-eclipse-plugin

Length of output: 2773

🏁 Script executed:

# Search for any other instances of the misspelled "espessif" in the codebase
rg "espessif" --type-list | head -5

Repository: espressif/idf-eclipse-plugin

Length of output: 461

🏁 Script executed:

# Search for any other instances of the misspelled "espessif" in the codebase
rg "espessif" -n

Repository: espressif/idf-eclipse-plugin

Length of output: 187

Plugin ID typo in standbyPageId URL will break resource resolution at runtime.

Line 8 references com.espessif.idf.ui (missing 'r'), but the bundle's symbolic name is com.espressif.idf.ui (as declared in MANIFEST.MF line 4). The platform: protocol requires an exact match to the bundle ID. This mismatch will cause the URL to fail resolution, breaking the standby page.

Fix:

-            url="platform:/plugin/com.espessif.idf.ui/index.html"/>
+            url="platform:/plugin/com.espressif.idf.ui/index.html"/>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
url="platform:/plugin/com.espessif.idf.ui/index.html"/>
url="platform:/plugin/com.espressif.idf.ui/index.html"/>
🤖 Prompt for AI Agents 
In bundles/com.espressif.idf.ui/introcontent.xml around line 8, the
standbyPageId URL uses the wrong bundle ID `com.espessif.idf.ui` (typo: missing
'r') which prevents platform:/plugin resolution; update the url attribute to the
correct bundle symbolic name `com.espressif.idf.ui` so the platform:/plugin path
matches the bundle ID declared in MANIFEST.MF and the standby page resource can
be resolved at runtime.

</introContent>
Loading