IEP-1022: Improve sdkconfig search functionality #819
Conversation
WalkthroughThe changes primarily focus on enhancing the search functionality in the Changes
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Files selected for processing (1)
- bundles/com.espressif.idf.sdk.config.ui/src/com/espressif/idf/sdk/config/ui/SDKConfigurationFilter.java (2 hunks)
Additional comments (Suppressed): 2
bundles/com.espressif.idf.sdk.config.ui/src/com/espressif/idf/sdk/config/ui/SDKConfigurationFilter.java (2)
10-21: The changes in this hunk look good. The function
isLeafMatchnow checks both the title and name of theKConfigMenuItemwhich should improve the search functionality as described in the PR summary.25-36: This hunk also looks good. The function
recursiveMatchnow checks both the title and name of theKConfigMenuItemand its children, which should further enhance the search functionality.
kolipakakondal
left a comment
kolipakakondal
left a comment
There was a problem hiding this comment.
This is really helpful. LGTM
|
Hi @AndriiFilippov Please verify this |
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Files selected for processing (1)
- bundles/com.espressif.idf.sdk.config.ui/src/com/espressif/idf/sdk/config/ui/SDKConfigurationFilter.java (2 hunks)
Additional comments (Suppressed): 2
bundles/com.espressif.idf.sdk.config.ui/src/com/espressif/idf/sdk/config/ui/SDKConfigurationFilter.java (2)
10-21: The changes in this hunk are enhancing the search functionality by allowing users to search for Kconfig elements not only by their titles but also by their names. This is a good improvement for usability.
25-36: Similar to the previous hunk, this change enhances the recursive search functionality by checking both the name and title of each KconfigMenuItem. This should improve the depth and accuracy of the search results.
|
@sigmaaa hi! Tested: Able to find under name / update / save / build. |
Description
Improved sdkconfig filter functionality. Now filtering allows compare not only the Kconfig elements' title but their names (UI labels) as well.
Fixes # (IEP-1022)
Type of change
Please delete options that are not relevant.
How has this been tested?
open sdkconfig editor. Try to search different components by label's name. For example "After flashing" gives
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit
KConfigMenuItemobjects not only by theirtitleproperty but also by theirnameproperty, providing a more comprehensive and flexible search experience.