WIP: Serial monitor issue #829
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes primarily focus on the removal of certain library dependencies from the classpath and build configurations across multiple project bundles. This suggests a shift towards using different libraries or methods for handling websockets and logging, improving the overall project structure and maintainability. Changes
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Files ignored due to filter (4)
- bundles/com.espressif.idf.serial.monitor/lib/slf4j.api-1.6.1.jar
- bundles/com.espressif.idf.terminal.connector.serial/lib/Java-WebSocket-1.5.2.jar
- bundles/com.espressif.idf.terminal.connector.serial/lib/javax.websocket-client-api-1.1.jar
- bundles/com.espressif.idf.terminal.connector.serial/lib/slf4j.api-1.6.1.jar
Files selected for processing (6)
- bundles/com.espressif.idf.serial.monitor/.classpath (1 hunks)
- bundles/com.espressif.idf.serial.monitor/META-INF/MANIFEST.MF (2 hunks)
- bundles/com.espressif.idf.serial.monitor/build.properties (1 hunks)
- bundles/com.espressif.idf.terminal.connector.serial/.classpath (1 hunks)
- bundles/com.espressif.idf.terminal.connector.serial/META-INF/MANIFEST.MF (1 hunks)
- bundles/com.espressif.idf.terminal.connector.serial/build.properties (1 hunks)
Files skipped from review due to trivial changes (6)
- bundles/com.espressif.idf.serial.monitor/.classpath
- bundles/com.espressif.idf.serial.monitor/META-INF/MANIFEST.MF
- bundles/com.espressif.idf.serial.monitor/build.properties
- bundles/com.espressif.idf.terminal.connector.serial/.classpath
- bundles/com.espressif.idf.terminal.connector.serial/META-INF/MANIFEST.MF
- bundles/com.espressif.idf.terminal.connector.serial/build.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed.
Fixes # (IEP-XXX)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit
"Refactor":
slf4j.api-1.6.1.jarincom.espressif.idf.serial.monitorand replaced it with a required bundleorg.slf4j.api.org.java_websocket,org.java_websocket.handshake, andorg.java_websocket.serverincom.espressif.idf.serial.monitor.Java-WebSocket-1.5.2.jarandjavax.websocket-client-api-1.1.jarincom.espressif.idf.terminal.connector.serial.These changes streamline the project's dependencies, improving maintainability and reducing potential conflicts.