Skip to content

IEP-1041: Parse Compile Commands File exception when using multiple esp-idf versions #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2023
Merged

IEP-1041: Parse Compile Commands File exception when using multiple esp-idf versions #835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bundles/com.espressif.idf.core/src/com/espressif/idf/core/build/IDFBuildConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1245,6 +1245,10 @@ private IFile getFileForCMakePath(String sourceFileName, IProject project)
pathtolookfor = getIdfToolsPath();
startIndex = sourceFile.indexOf(pathtolookfor);
}
if (startIndex == -1) // source file still not found means it was part of another esp-idf
{
return null;
}
Copy link
Collaborator

@kolipakakondal kolipakakondal Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That meanspathtolookfor = getIdfToolsPath(); was not returning the correct IDF_PATH, I wonder why IDF_PATH is not configured correctly and what are the other issues it might cause!

If user switched to a different esp-idf version then IDF_PATH would have modified accordingly.

Copy link
Collaborator Author

@sigmaaa sigmaaa Nov 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kolipakakondal, the IDF_PATH from getIdfToolsPath() is correct, the issue happens because sourceFile is pointing to the different esp-idf. I think the sourceFile is provided based on the files from the build folder. This issue happens when we build the project with the different esp-idf version, then switch esp-idf and trying to build project again without cleaning build folder

String relativePath = sourceFile.substring(startIndex + pathtolookfor.length() + 1);

IPath projectPath = getComponentsPath().append(relativePath);
Expand Down