-
Notifications
You must be signed in to change notification settings - Fork 133
fix(updatesite): Add org.slf4j pkg to fix serial monitor launch #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe change introduced in this pull request is a new dependency on the Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (1)
- bundles/com.espressif.idf.terminal.connector.serial/META-INF/MANIFEST.MF (1 hunks)
Additional comments (Suppressed): 1
bundles/com.espressif.idf.terminal.connector.serial/META-INF/MANIFEST.MF (1)
- 30-30: The
org.slf4jpackage has been added to theImport-Packagesection, indicating a new dependency. Ensure that theorg.slf4jlibrary is available in the runtime environment to avoid anyClassNotFoundExceptionorNoClassDefFoundErrorexceptions.
|
Hi @AndriiFilippov Please verify if you are able to use serial monitor |
sigmaaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@kolipakakondal, hi ! Tested under:
|
As we verified, we couldn't reproduce this issue on windows and macOS with the eclipse 2023-09. |

Description
Please include a summary of the change and which issue is fixed.
Fixes # (IEP-XXX)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit
org.slf4jlibrary to improve the way we track and manage system events. This will help us diagnose and resolve issues more efficiently, leading to a more reliable and stable user experience.