Skip to content

Conversation

@kolipakakondal
Copy link
Collaborator

@kolipakakondal kolipakakondal commented Oct 19, 2023

Description

Please include a summary of the change and which issue is fixed.

Fixes # (IEP-XXX)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • New Feature: Enhanced logging capabilities in the terminal connector. We've integrated the org.slf4j library to improve the way we track and manage system events. This will help us diagnose and resolve issues more efficiently, leading to a more reliable and stable user experience.

@coderabbitai
Copy link

coderabbitai bot commented Oct 19, 2023

Walkthrough

The change introduced in this pull request is a new dependency on the org.slf4j library in the com.espressif.idf.terminal.connector.serial bundle. This suggests an enhancement in logging capabilities within the terminal connector serial component.

Changes

File Summary
.../connector.serial/META-INF/MANIFEST.MF Added org.slf4j to the Import-Package section, indicating a new dependency on this logging library.

🐇

"In the realm of code, changes small and neat,

A logging library, our old friend we greet.

With slf4j in hand, we march ahead,

To trace our steps, and nothing left unsaid. 🎉"


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between f3598d0 and a247edc.
Files selected for processing (1)
  • bundles/com.espressif.idf.terminal.connector.serial/META-INF/MANIFEST.MF (1 hunks)
Additional comments (Suppressed): 1
bundles/com.espressif.idf.terminal.connector.serial/META-INF/MANIFEST.MF (1)
  • 30-30: The org.slf4j package has been added to the Import-Package section, indicating a new dependency. Ensure that the org.slf4j library is available in the runtime environment to avoid any ClassNotFoundException or NoClassDefFoundError exceptions.

@kolipakakondal
Copy link
Collaborator Author

Hi @AndriiFilippov Please verify if you are able to use serial monitor

Copy link
Collaborator

@sigmaaa sigmaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndriiFilippov
Copy link
Collaborator

@kolipakakondal, hi !

Tested under:
OS - Windows 10 / Linux Ubuntu 20.04 / MacOS
ESP-IDF: v5.1.1

LGTM 👍
image

  1. Eclipse 23-09 + 2.11.1 zip works but getting errors during installation:
Your original request has been modified.
  "Language Server Protocol client for Eclipse IDE (Incubation)" is already installed, so an update will be performed instead.
Cannot complete the install because one or more required items could not be found.
  Software being installed: Eclipse SWTChart 0.13.0.202009151159 (org.eclipse.swtchart.feature.feature.group 0.13.0.202009151159)
  Missing requirement: Batik DOM implementation 1.9.1.v20190730-1743 (org.apache.batik.dom 1.9.1.v20190730-1743) requires 'java.package; org.apache.xml.utils 2.7.1' but it could not be found
  Cannot satisfy dependency:
    From: Eclipse SWTChart 0.13.0.202009151159 (org.eclipse.swtchart.feature.feature.group 0.13.0.202009151159)
    To: org.eclipse.equinox.p2.iu; org.apache.batik.dom [1.9.1.v20190730-1743,1.9.1.v20190730-1743]

@kolipakakondal
Copy link
Collaborator Author

Missing requirement: Batik DOM implementation 1.9.1.v20190730-1743 (org.apache.batik.dom 1.9.1.v20190730-1743) requires 'java.package; org.apache.xml.utils 2.7.1' but it could not be found
Cannot satisfy dependency:
From: Eclipse SWTChart 0.13.0.202009151159 (org.eclipse.swtchart.feature.feature.group 0.13.0.202009151159)
To: org.eclipse.equinox.p2.iu; org.apache.batik.dom [1.9.1.v20190730-1743,1.9.1.v20190730-1743]

As we verified, we couldn't reproduce this issue on windows and macOS with the eclipse 2023-09.

@kolipakakondal kolipakakondal added this to the 2.11.1 milestone Oct 24, 2023
@kolipakakondal kolipakakondal added the bug Something isn't working label Oct 24, 2023
@kolipakakondal kolipakakondal merged commit b152760 into master Oct 24, 2023
@kolipakakondal kolipakakondal deleted the IEP-1044 branch October 24, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants