Skip to content

Commit 0a17c86

Browse files
committed
For the time of being, we are turning off the codesigning of the windows binaries
1 parent 5bd69ea commit 0a17c86

File tree

1 file changed

+52
-52
lines changed

1 file changed

+52
-52
lines changed

.github/workflows/build.yaml

Lines changed: 52 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -324,24 +324,24 @@ jobs:
324324
zip -r eim.zip eim
325325
shell: bash
326326

327-
- name: Sign Windows Binary
328-
if: runner.os == 'Windows'
329-
env:
330-
WINDOWS_PFX_FILE: ${{ secrets.WIN_CERTIFICATE }}
331-
WINDOWS_PFX_PASSWORD: ${{ secrets.WIN_CERTIFICATE_PWD }}
332-
run: |
333-
echo $env:WINDOWS_PFX_FILE | Out-File -FilePath cert.b64 -Encoding ASCII
334-
certutil -decode cert.b64 cert.pfx
335-
Remove-Item cert.b64
336-
$signtool = Get-ChildItem -Path "C:\Program Files (x86)\Windows Kits\10\bin" -Recurse -Filter signtool.exe |
337-
Sort-Object FullName -Descending |
338-
Select-Object -First 1
339-
340-
if (-not $signtool) {
341-
Write-Error "signtool.exe not found on the runner"
342-
exit 1
343-
}
344-
& $signtool.FullName sign /f cert.pfx /p $env:WINDOWS_PFX_PASSWORD /tr http://timestamp.digicert.com /td sha256 /fd sha256 release_cli/${{ matrix.package_name }}/eim.exe
327+
# - name: Sign Windows Binary
328+
# if: runner.os == 'Windows'
329+
# env:
330+
# WINDOWS_PFX_FILE: ${{ secrets.WIN_CERTIFICATE }}
331+
# WINDOWS_PFX_PASSWORD: ${{ secrets.WIN_CERTIFICATE_PWD }}
332+
# run: |
333+
# echo $env:WINDOWS_PFX_FILE | Out-File -FilePath cert.b64 -Encoding ASCII
334+
# certutil -decode cert.b64 cert.pfx
335+
# Remove-Item cert.b64
336+
# $signtool = Get-ChildItem -Path "C:\Program Files (x86)\Windows Kits\10\bin" -Recurse -Filter signtool.exe |
337+
# Sort-Object FullName -Descending |
338+
# Select-Object -First 1
339+
340+
# if (-not $signtool) {
341+
# Write-Error "signtool.exe not found on the runner"
342+
# exit 1
343+
# }
344+
# & $signtool.FullName sign /f cert.pfx /p $env:WINDOWS_PFX_PASSWORD /tr http://timestamp.digicert.com /td sha256 /fd sha256 release_cli/${{ matrix.package_name }}/eim.exe
345345

346346
- name: Codesign macOS Binary
347347
if: startsWith(matrix.os, 'macos')
@@ -441,21 +441,21 @@ jobs:
441441
zip -r offline_installer_builder.zip offline_installer_builder
442442
shell: bash
443443

444-
- name: Sign Windows offline_installer_builder Binary
445-
if: runner.os == 'Windows'
446-
env:
447-
WINDOWS_PFX_FILE: ${{ secrets.WIN_CERTIFICATE }}
448-
WINDOWS_PFX_PASSWORD: ${{ secrets.WIN_CERTIFICATE_PWD }}
449-
run: |
450-
$signtool = Get-ChildItem -Path "C:\Program Files (x86)\Windows Kits\10\bin" -Recurse -Filter signtool.exe |
451-
Sort-Object FullName -Descending |
452-
Select-Object -First 1
453-
454-
if (-not $signtool) {
455-
Write-Error "signtool.exe not found on the runner"
456-
exit 1
457-
}
458-
& $signtool.FullName sign /f cert.pfx /p $env:WINDOWS_PFX_PASSWORD /tr http://timestamp.digicert.com /td sha256 /fd sha256 release_cli/${{ matrix.package_name }}/offline_installer_builder.exe
444+
# - name: Sign Windows offline_installer_builder Binary
445+
# if: runner.os == 'Windows'
446+
# env:
447+
# WINDOWS_PFX_FILE: ${{ secrets.WIN_CERTIFICATE }}
448+
# WINDOWS_PFX_PASSWORD: ${{ secrets.WIN_CERTIFICATE_PWD }}
449+
# run: |
450+
# $signtool = Get-ChildItem -Path "C:\Program Files (x86)\Windows Kits\10\bin" -Recurse -Filter signtool.exe |
451+
# Sort-Object FullName -Descending |
452+
# Select-Object -First 1
453+
454+
# if (-not $signtool) {
455+
# Write-Error "signtool.exe not found on the runner"
456+
# exit 1
457+
# }
458+
# & $signtool.FullName sign /f cert.pfx /p $env:WINDOWS_PFX_PASSWORD /tr http://timestamp.digicert.com /td sha256 /fd sha256 release_cli/${{ matrix.package_name }}/offline_installer_builder.exe
459459

460460
- name: Codesign macOS offline_installer_builder Binary
461461
if: startsWith(matrix.os, 'macos')
@@ -620,25 +620,25 @@ jobs:
620620
APP_INSIGHTS_CONNECTION_STRING: ${{ secrets.APP_INSIGHTS_CONNECTION_STRING }}
621621
run: yarn tauri build
622622

623-
- name: Sign Windows Binary
624-
if: runner.os == 'Windows'
625-
env:
626-
WINDOWS_PFX_FILE: ${{ secrets.WIN_CERTIFICATE }}
627-
WINDOWS_PFX_PASSWORD: ${{ secrets.WIN_CERTIFICATE_PWD }}
628-
run: |
629-
echo $env:WINDOWS_PFX_FILE | Out-File -FilePath cert.b64 -Encoding ASCII
630-
certutil -decode cert.b64 cert.pfx
631-
Remove-Item cert.b64
632-
$signtool = Get-ChildItem -Path "C:\Program Files (x86)\Windows Kits\10\bin" -Recurse -Filter signtool.exe |
633-
Sort-Object FullName -Descending |
634-
Select-Object -First 1
635-
636-
if (-not $signtool) {
637-
Write-Error "signtool.exe not found on the runner"
638-
exit 1
639-
}
640-
641-
& $signtool.FullName sign /f cert.pfx /p $env:WINDOWS_PFX_PASSWORD /tr http://timestamp.digicert.com /td sha256 /fd sha256 .\src-tauri\target\release\eim.exe
623+
# - name: Sign Windows Binary
624+
# if: runner.os == 'Windows'
625+
# env:
626+
# WINDOWS_PFX_FILE: ${{ secrets.WIN_CERTIFICATE }}
627+
# WINDOWS_PFX_PASSWORD: ${{ secrets.WIN_CERTIFICATE_PWD }}
628+
# run: |
629+
# echo $env:WINDOWS_PFX_FILE | Out-File -FilePath cert.b64 -Encoding ASCII
630+
# certutil -decode cert.b64 cert.pfx
631+
# Remove-Item cert.b64
632+
# $signtool = Get-ChildItem -Path "C:\Program Files (x86)\Windows Kits\10\bin" -Recurse -Filter signtool.exe |
633+
# Sort-Object FullName -Descending |
634+
# Select-Object -First 1
635+
636+
# if (-not $signtool) {
637+
# Write-Error "signtool.exe not found on the runner"
638+
# exit 1
639+
# }
640+
641+
# & $signtool.FullName sign /f cert.pfx /p $env:WINDOWS_PFX_PASSWORD /tr http://timestamp.digicert.com /td sha256 /fd sha256 .\src-tauri\target\release\eim.exe
642642

643643
- name: Handle Linux artifacts
644644
if: startsWith(matrix.os, 'ubuntu')

0 commit comments

Comments
 (0)