-
Notifications
You must be signed in to change notification settings - Fork 2
[Test] Fix CLI test #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Fix CLI test #284
Conversation
Enable extended test on release branch PR
Summary of ChangesHello @Fabricio-ESP, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the robustness and coverage of CLI tests. It resolves a small typographical error in a test script, rectifies an issue with test artifact naming, and expands the execution of extended tests to include pull requests targeting release branches, ensuring more comprehensive validation. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides a fix for a typo in a CLI test, changing 'for download' to 'to download' in an expected output string. This correction is accurate and improves the reliability of the test. The review is based solely on this change, as other modifications mentioned in the PR description were not part of the provided diff. I've reviewed the change and found no issues to report.
Hahihula
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... didn't see that either... Thanks for quick fix
Enable extended test on release branch PR
Description
This PR provides a fix for:
Additionally this enables extended test when a PR is created for a release branch.
Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: