Skip to content

Conversation

@Fabricio-ESP
Copy link
Collaborator

Enable extended test on release branch PR

Description

This PR provides a fix for:

  • Typo in the CLI test (wizard install mode)
  • Incorrect naming of the test artifacts when self-hosted test is enabled
    Additionally this enables extended test when a PR is created for a release branch.

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Fabricio-ESP, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the robustness and coverage of CLI tests. It resolves a small typographical error in a test script, rectifies an issue with test artifact naming, and expands the execution of extended tests to include pull requests targeting release branches, ensuring more comprehensive validation.

Highlights

  • CLI Test Typo Fix: Corrected a minor typo in the CLIWizardInstall.test.js file, specifically in the expected output string for the PyPI mirror selection prompt during the wizard installation test.
  • Test Artifact Naming: Addressed an issue with incorrect naming of test artifacts when self-hosted tests are enabled.
  • Extended Test Enablement: Enabled extended tests to run automatically when a pull request is created for a release branch, enhancing test coverage for critical branches.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/build.yaml
    • .github/workflows/test_cli.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a fix for a typo in a CLI test, changing 'for download' to 'to download' in an expected output string. This correction is accurate and improves the reliability of the test. The review is based solely on this change, as other modifications mentioned in the PR description were not part of the provided diff. I've reviewed the change and found no issues to report.

Copy link
Collaborator

@Hahihula Hahihula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... didn't see that either... Thanks for quick fix

@Fabricio-ESP Fabricio-ESP merged commit a8746f4 into master Nov 26, 2025
3 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants