Skip to content

[Test] Fix CLI test #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2025
Merged

[Test] Fix CLI test #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f6f0f4
Fix CLI test typo
Fabricio-ESP Nov 25, 2025
51f26d0
Fix artifact name and workflow cleaning step
Fabricio-ESP Nov 25, 2025
7aadf45
Fix offline test workflow call. Pin python 3.13.8
Fabricio-ESP Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,7 +861,7 @@ jobs:
with:
run_id: ${{ github.run_id }}
ref: ${{ github.event.pull_request.head.ref || github.ref }}
run_extended: ${{(github.event_name == 'release' && github.event.action == 'created') || github.event_name == 'schedule' || (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'EXTENDEDTEST'))}}
run_extended: ${{(github.event_name == 'release' && github.event.action == 'created') || github.event_name == 'schedule' || (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'EXTENDEDTEST')) || startsWith(github.event.pull_request.head.ref, 'release')}}
run_self_hosted: ${{(github.event_name == 'release' && github.event.action == 'created') || github.event_name == 'schedule' || (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'CNRUNNER'))}}

Autotest-GUI:
Expand All @@ -872,7 +872,7 @@ jobs:
with:
run_id: ${{ github.run_id }}
ref: ${{ github.event.pull_request.head.ref || github.ref }}
run_extended: ${{(github.event_name == 'release' && github.event.action == 'created') || github.event_name == 'schedule' || (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'EXTENDEDTEST'))}}
run_extended: ${{(github.event_name == 'release' && github.event.action == 'created') || github.event_name == 'schedule' || (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'EXTENDEDTEST')) || startsWith(github.event.pull_request.head.ref, 'release')}}

update-release-info:
name: Update Release Information
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/build_offline_installer_archives.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,3 +583,4 @@ jobs:
with:
ref: ${{ inputs.ref || github.ref }}
run_id: ${{ github.run_id }}
eim_cli_run_id: ${{ (github.event_name == 'workflow_call' && inputs.run_id) || 'release' }}
6 changes: 3 additions & 3 deletions .github/workflows/test_cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ jobs:
uses: actions/upload-artifact@v4
if: matrix.os != 'windows-latest'
with:
name: autotest-CLI-results-${{ matrix.package_name }}${{ matrix.run_on == 'MirrorRunner' && '-AlternateMirrors' || '' }}${{inputs.run_self_hosted == 'true' && '-CN' || '' }}
name: autotest-CLI-results-${{ matrix.package_name }}${{ matrix.run_on == 'MirrorRunner' && '-AlternateMirrors' || '' }}$${{ matrix.os == 'self-hosted' && '-CN' || '' }}
path: |
./tests/results-*.json
./tests/*.log
Expand All @@ -257,13 +257,13 @@ jobs:
uses: actions/upload-artifact@v4
if: matrix.os == 'windows-latest'
with:
name: autotest-CLI-results-${{ matrix.package_name }}${{ matrix.run_on == 'MirrorRunner' && '-AlternateMirrors' || '' }}${inputs.run_self_hosted == 'true' && '-CN' || '' }}
name: autotest-CLI-results-${{ matrix.package_name }}
path: |
./tests/results-*.json
./tests/*.log

- name: Clean Up runner (Self-hosted MirrorRunner)
if: matrix.run_on == 'MirrorRunner' && inputs.run_self_hosted == 'true'
if: matrix.run_on == 'MirrorRunner' && matrix.os == 'self-hosted'
run: |
rm -rf ~/.local/share/eim
rm -rf ~/runner/_work/idf-im-ui
Expand Down
10 changes: 3 additions & 7 deletions .github/workflows/test_offline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: "3.13"
python-version: "3.13.8"

- name: Download Build Info files
uses: actions/download-artifact@v5
Expand Down Expand Up @@ -122,6 +122,7 @@ jobs:
- name: Run IDF offline installation (non-Windows)
if: matrix.os != 'windows-latest'
run: |
python3 --version
export LOG_TO_FILE="true"
export EIM_CLI_PATH="../artifacts/eim"
export BUILD_INFO_PATH="../artifacts"
Expand All @@ -140,15 +141,10 @@ jobs:

ls ./artifacts/

- name: Update Python (Windows)
if: matrix.os == 'windows-latest'
uses: actions/setup-python@v6
with:
python-version: "3.11"

- name: Run IDF offline installation (Windows)
if: matrix.os == 'windows-latest'
run: |
python3 --version
$env:LOG_TO_FILE="true"
$env:EIM_CLI_PATH = "..\artifacts\eim.exe"
$env:BUILD_INFO_PATH = "..\artifacts"
Expand Down
2 changes: 1 addition & 1 deletion tests/scripts/CLIWizardInstall.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ export function runCLIWizardInstallTest({
await new Promise((resolve) => setTimeout(resolve, 500));

const selectPyPIMirror = await testRunner.waitForOutput(
"Select a PyPI mirror for download Python packages"
"Select a PyPI mirror to download Python packages"
);
expect(selectPyPIMirror, "Failed to ask for PyPI download mirror").to.be
.true;
Expand Down
Loading