Skip to content

reenabling the windows binaries signing process in the CI pipeline #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

reenabling the windows binaries signing process in the CI pipeline #287

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d98d78
reenabling the windows binaries signing process in the CI pipeline
Hahihula Nov 28, 2025
7344fa2
removed password
Hahihula Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 52 additions & 52 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,24 +360,24 @@ jobs:
zip -r eim.zip eim
shell: bash

# - name: Sign Windows Binary
# if: runner.os == 'Windows'
# env:
# WINDOWS_PFX_FILE: ${{ secrets.WIN_CERTIFICATE }}
# WINDOWS_PFX_PASSWORD: ${{ secrets.WIN_CERTIFICATE_PWD }}
# run: |
# echo $env:WINDOWS_PFX_FILE | Out-File -FilePath cert.b64 -Encoding ASCII
# certutil -decode cert.b64 cert.pfx
# Remove-Item cert.b64
# $signtool = Get-ChildItem -Path "C:\Program Files (x86)\Windows Kits\10\bin" -Recurse -Filter signtool.exe |
# Sort-Object FullName -Descending |
# Select-Object -First 1

# if (-not $signtool) {
# Write-Error "signtool.exe not found on the runner"
# exit 1
# }
# & $signtool.FullName sign /f cert.pfx /p $env:WINDOWS_PFX_PASSWORD /tr http://timestamp.digicert.com /td sha256 /fd sha256 release_cli/${{ matrix.package_name }}/eim.exe
- name: Sign Windows Binary
if: runner.os == 'Windows'
env:
WINDOWS_PFX_FILE: ${{ secrets.GLOBALSIGN_PFX_BASE64 }}
WINDOWS_PFX_PASSWORD: ""
run: |
echo $env:WINDOWS_PFX_FILE | Out-File -FilePath cert.b64 -Encoding ASCII
certutil -decode cert.b64 cert.pfx
Remove-Item cert.b64
$signtool = Get-ChildItem -Path "C:\Program Files (x86)\Windows Kits\10\bin" -Recurse -Filter signtool.exe |
Sort-Object FullName -Descending |
Select-Object -First 1

if (-not $signtool) {
Write-Error "signtool.exe not found on the runner"
exit 1
}
& $signtool.FullName sign /f cert.pfx /tr http://timestamp.digicert.com /td sha256 /fd sha256 release_cli/${{ matrix.package_name }}/eim.exe

- name: Codesign macOS Binary
if: startsWith(matrix.os, 'macos')
Expand Down Expand Up @@ -477,21 +477,21 @@ jobs:
zip -r offline_installer_builder.zip offline_installer_builder
shell: bash

# - name: Sign Windows offline_installer_builder Binary
# if: runner.os == 'Windows'
# env:
# WINDOWS_PFX_FILE: ${{ secrets.WIN_CERTIFICATE }}
# WINDOWS_PFX_PASSWORD: ${{ secrets.WIN_CERTIFICATE_PWD }}
# run: |
# $signtool = Get-ChildItem -Path "C:\Program Files (x86)\Windows Kits\10\bin" -Recurse -Filter signtool.exe |
# Sort-Object FullName -Descending |
# Select-Object -First 1

# if (-not $signtool) {
# Write-Error "signtool.exe not found on the runner"
# exit 1
# }
# & $signtool.FullName sign /f cert.pfx /p $env:WINDOWS_PFX_PASSWORD /tr http://timestamp.digicert.com /td sha256 /fd sha256 release_cli/${{ matrix.package_name }}/offline_installer_builder.exe
- name: Sign Windows offline_installer_builder Binary
if: runner.os == 'Windows'
env:
WINDOWS_PFX_FILE: ${{ secrets.GLOBALSIGN_PFX_BASE64 }}
WINDOWS_PFX_PASSWORD: ""
run: |
$signtool = Get-ChildItem -Path "C:\Program Files (x86)\Windows Kits\10\bin" -Recurse -Filter signtool.exe |
Sort-Object FullName -Descending |
Select-Object -First 1

if (-not $signtool) {
Write-Error "signtool.exe not found on the runner"
exit 1
}
& $signtool.FullName sign /f cert.pfx /tr http://timestamp.digicert.com /td sha256 /fd sha256 release_cli/${{ matrix.package_name }}/offline_installer_builder.exe

- name: Codesign macOS offline_installer_builder Binary
if: startsWith(matrix.os, 'macos')
Expand Down Expand Up @@ -657,25 +657,25 @@ jobs:
APP_INSIGHTS_CONNECTION_STRING: ${{ secrets.APP_INSIGHTS_CONNECTION_STRING }}
run: yarn tauri build

# - name: Sign Windows Binary
# if: runner.os == 'Windows'
# env:
# WINDOWS_PFX_FILE: ${{ secrets.WIN_CERTIFICATE }}
# WINDOWS_PFX_PASSWORD: ${{ secrets.WIN_CERTIFICATE_PWD }}
# run: |
# echo $env:WINDOWS_PFX_FILE | Out-File -FilePath cert.b64 -Encoding ASCII
# certutil -decode cert.b64 cert.pfx
# Remove-Item cert.b64
# $signtool = Get-ChildItem -Path "C:\Program Files (x86)\Windows Kits\10\bin" -Recurse -Filter signtool.exe |
# Sort-Object FullName -Descending |
# Select-Object -First 1

# if (-not $signtool) {
# Write-Error "signtool.exe not found on the runner"
# exit 1
# }

# & $signtool.FullName sign /f cert.pfx /p $env:WINDOWS_PFX_PASSWORD /tr http://timestamp.digicert.com /td sha256 /fd sha256 .\src-tauri\target\release\eim.exe
- name: Sign Windows Binary
if: runner.os == 'Windows'
env:
WINDOWS_PFX_FILE: ${{ secrets.GLOBALSIGN_PFX_BASE64 }}
WINDOWS_PFX_PASSWORD: ""
run: |
echo $env:WINDOWS_PFX_FILE | Out-File -FilePath cert.b64 -Encoding ASCII
certutil -decode cert.b64 cert.pfx
Remove-Item cert.b64
$signtool = Get-ChildItem -Path "C:\Program Files (x86)\Windows Kits\10\bin" -Recurse -Filter signtool.exe |
Sort-Object FullName -Descending |
Select-Object -First 1

if (-not $signtool) {
Write-Error "signtool.exe not found on the runner"
exit 1
}

& $signtool.FullName sign /f cert.pfx /p $env:WINDOWS_PFX_PASSWORD /tr http://timestamp.digicert.com /td sha256 /fd sha256 .\src-tauri\target\release\eim.exe

- name: Handle Linux artifacts
if: startsWith(matrix.os, 'ubuntu')
Expand Down
Loading