update: extended git reset and update submodules for all installer versions

Fixes espressif/esp-idf#15754

Author: Marek Fiala

src/InnoSetup/Environment.iss

@@ -198,7 +198,7 @@ begin
 end;
 
 {
-  Initialize submodules - required to call when switching branches in existing repo.
+  Initialize submodules
   E.g. created by offline installer
 }
 procedure GitUpdateSubmodules(Path: String);
@@ -287,6 +287,9 @@ begin
   DoCmdlineInstall(CustomMessage('UpdatingSubmodules'), CustomMessage('UpdatingSubmodules'), Command);
 end;
 
+{
+  Note: This procedure is not invoked for offline installer
+}
 procedure IDFDownloadInstall();
 var
   CmdLine: String;
@@ -400,9 +403,6 @@ begin
     CmdLine := ExpandConstant('cmd.exe /c ""xcopy.exe" /s /e /i /h /q "' + IDFTempPath + '" "' + IDFPath + '""');
     DoCmdlineInstall(CustomMessage('ExtractingEspIdf'), CustomMessage('CopyingEspIdf'), CmdLine);
 
-    GitRepoFixFileMode(IDFPath);
-    GitResetHard(IDFPath);
-
     DelTree(IDFTempPath, True, True, True);
   end;
 end;

src/InnoSetup/PostInstall.iss

@@ -238,6 +238,9 @@ begin
         end;
       end;
 
+      GitRepoFixFileMode(IDFDownloadPath);
+      GitResetHard(IDFDownloadPath);
+      GitUpdateSubmodules(IDFDownloadPath);
       IDFToolsSetup();
       SaveIdfConfiguration(ExpandConstant('{app}\esp_idf.json'));
     end;