fix: Build workflow fixes

Author: jakub-kocka

.github/workflows/build-installer.yml

@@ -36,23 +36,23 @@ jobs:
     build-installer-online:
         name: Build Online Installer
         if: inputs.installer_type == 'online'
-        uses: espressif/idf-installer/.github/workflows/build-online-installer.yml
+        uses: espressif/idf-installer/.github/workflows/build-online-installer.yml@main
         with:
             online_installer_version: ${{ inputs.online_installer_version }}
         secrets: inherit
 
     build-installer-offline:
         name: Build Offline Installer
         if: inputs.installer_type == 'offline'
-        uses: espressif/idf-installer/.github/workflows/build-offline-installer.yml
+        uses: espressif/idf-installer/.github/workflows/build-offline-installer.yml@fix/installer_builds
         with:
-            esp_idf_version: ${{ inputs.esp_idf_version}}
+            esp_idf_version: ${{ inputs.esp_idf_version }}
         secrets: inherit
 
     build-installer-ide:
         name: Build IDE Installer
         if: inputs.installer_type == 'espressif-ide'
-        uses: espressif/idf-installer/.github/workflows/build-espressif-ide-installer.yml
+        uses: espressif/idf-installer/.github/workflows/build-espressif-ide-installer.yml@main
         with:
             esp_idf_version: ${{ inputs.esp_idf_version }}
             espressif_ide_version: ${{ inputs.espressif_ide_version }}
@@ -61,7 +61,7 @@ jobs:
     update-docs-files:
         needs: [build-installer-online, build-installer-offline, build-installer-ide]
         name: Create ${{ github.env.INSTALLER_TYPE }} installer release PR
-        if: ${{ always() }} && (${{ needs.build-installer-ide.result }} == 'success' || ${{ needs.build-installer-offline.result }} == 'success' || ${{ needs.build-installer-online.result }} == 'success')
+        if: ${{ always() && (needs.build-installer-ide.result == 'success' || needs.build-installer-offline.result == 'success' || needs.build-installer-online.result == 'success') }}
         runs-on: windows-latest
         strategy:
             fail-fast: false
@@ -85,7 +85,7 @@ jobs:
 
             - name: Get size of online installer and Update docs files
               run: |
-                echo "Instaler size from variable is $(Get-Content variables.txt)"
+                echo "Installer size from variable is $(Get-Content variables.txt)"
 
                 $size_bytes = [int]$(Get-Content variables.txt)
                 # Check if the content is larger than 100000

.github/workflows/build-offline-installer.yml

@@ -14,7 +14,7 @@ env:
 jobs:
   build-offline-installer:
     name: Build Installer
-    runs-on: windows-latest
+    runs-on: windows-2022
     steps:
       - name: Checkout repository
         uses: actions/checkout@v5
@@ -24,11 +24,20 @@ jobs:
         with:
           python-version: '3.11'
 
+      - name: Install Inno Setup
+        shell: pwsh
+        run: choco install innosetup inno-download-plugin
+
       - name: Install Inno Setup Download plugin
         shell: pwsh
         run: |
-          Write-Output $(pwd)
-          Invoke-WebRequest -Uri https://github.com/espressif/inno-download-plugin/releases/download/v1.5.1/idpsetup-1.5.1.exe -OutFile idpsetup.exe; .\idpsetup.exe /SILENT
+          $isAdmin = ([Security.Principal.WindowsPrincipal] [Security.Principal.WindowsIdentity]::GetCurrent()).IsInRole([Security.Principal.WindowsBuiltInRole]::Administrator)
+          Write-Output "Running as Administrator: $isAdmin"
+          Write-Output "Downloading Inno Download Plugin..."
+          Invoke-WebRequest -Uri https://github.com/espressif/inno-download-plugin/releases/download/v1.5.1/idpsetup-1.5.1.exe -OutFile idpsetup.exe
+          Write-Output "Installing Inno Download Plugin..."
+          .\idpsetup.exe /SP- /SUPPRESSMSGBOXES
+          Write-Output "Installation completed."
 
       - name: Build Installer
         env:

Build-Installer.ps1

@@ -268,8 +268,8 @@ function PrepareIdfPythonWheels {
 
         $ConstraintFile = GetConstraintFile
 
-        &$Python -m pip download --python-version $IdfPythonShortVersion `
-            --only-binary=":all:" `
+        &$Python -m pip download `
+            --prefer-binary `
             --extra-index-url "https://dl.espressif.com/pypi/" `
             -r ${Requirements} `
             -d ${WheelsDirectory} `
@@ -382,6 +382,10 @@ function FindSignTool {
     if (Test-Path -Path $SignTool -PathType Leaf) {
         return $SignTool
     }
+    $SignTool = "${env:ProgramFiles(x86)}\Windows Kits\10\bin\10.0.22621.0\x64\signtool.exe"
+    if (Test-Path -Path $SignTool -PathType Leaf) {
+        return $SignTool
+    }
     FailBuild -Message "signtool.exe not found"
 }