Fix of the Installer builds #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakub-kocka
force-pushed
the
fix/installer_builds
branch
3 times, most recently
from
02b8726 to
5f9ae5a
Compare
mfialaf
reviewed
Sep 25, 2025
| shell: pwsh | ||
| run: Invoke-WebRequest -Uri https://github.com/espressif/inno-download-plugin/releases/download/v1.5.1/idpsetup-1.5.1.exe -OutFile idpsetup.exe; .\idpsetup.exe /SILENT; Sleep 5 | ||
| run: | | ||
| pwd |
Collaborator
There was a problem hiding this comment.
Do we want to see current directory?
Maybe Write-Output pwd
Collaborator
Author
There was a problem hiding this comment.
I hope it is in the repo directory, but I have run into some issues in local testing with the command, so we would like to know better the place where it runs.
Thank you @mfialaf
jakub-kocka
force-pushed
the
fix/installer_builds
branch
from
5f9ae5a to
cf07c61
Compare
Collaborator
|
Thanks, LGTM |
Collaborator
Author
|
Thank you for the review. I am merging this to proceed with the following fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: