Skip to content

Commit ecd4c92

Browse files
authored
[dua] completely remove DUA features and configurations (openthread#13191)
This commit removes the OPENTHREAD_CONFIG_TMF_PROXY_DUA_ENABLE feature and all associated code, tests, CLI commands, and harness references. Changes: - Removed OPENTHREAD_CONFIG_TMF_PROXY_DUA_ENABLE definition and all assert/preprocessor checks. - Completely deleted dua_manager.cpp and dua_manager.hpp. - Removed DUA registration notifying and request URI paths. - Cleaned up all references to Domain Unicast Address (DUA) across child management, notifier, time ticker, and MLE. - Removed DUA commands and logic from the CLI and Python cert tests (including packet verifier). - Verified that the entire codebase compiles clean and all tests successfully pass using the Nexus test suite.
1 parent b69c905 commit ecd4c92

36 files changed

Lines changed: 56 additions & 1128 deletions

.github/workflows/otci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ jobs:
8080
PYTHONPATH=./tests/scripts/thread-cert pytype tools/otci
8181
- name: Build
8282
run: |
83-
./script/cmake-build simulation -DOT_THREAD_VERSION=1.4 -DOT_DUA=ON -DOT_MLR=ON -DOT_BACKBONE_ROUTER=ON \
83+
./script/cmake-build simulation -DOT_THREAD_VERSION=1.4 -DOT_MLR=ON -DOT_BACKBONE_ROUTER=ON \
8484
-DOT_CSL_RECEIVER=ON -DOT_SIMULATION_VIRTUAL_TIME=${VIRTUAL_TIME}
8585
- name: Install OTCI Python Library
8686
run: |

script/test

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,6 @@ do_build_otbr_docker()
350350
"-DOT_SRP_CLIENT=ON"
351351
"-DOT_FULL_LOGS=ON"
352352
"-DOT_UPTIME=ON"
353-
"-DOTBR_DUA_ROUTING=ON"
354353
"-DOTBR_DHCP6_PD=ON"
355354
)
356355
local args=(

src/cli/README.md

Lines changed: 0 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ Done
5050
- [discover](#discover-channel)
5151
- [dns](#dns-config)
5252
- [domainname](#domainname)
53-
- [dua](#dua-iid)
5453
- [eidcache](#eidcache)
5554
- [eui64](#eui64)
5655
- [extaddr](#extaddr)
@@ -174,30 +173,6 @@ BBR Primary: None
174173
Done
175174
```
176175

177-
### bbr mgmt dua \<status\|coap-code\> [meshLocalIid]
178-
179-
Configure the response status for DUA.req with meshLocalIid in payload. Without meshLocalIid, simply respond any coming DUA.req next with the specified status or COAP code.
180-
181-
Only for testing/reference device.
182-
183-
known status value:
184-
185-
- 0: ST_DUA_SUCCESS
186-
- 1: ST_DUA_REREGISTER
187-
- 2: ST_DUA_INVALID
188-
- 3: ST_DUA_DUPLICATE
189-
- 4: ST_DUA_NO_RESOURCES
190-
- 5: ST_DUA_BBR_NOT_PRIMARY
191-
- 6: ST_DUA_GENERAL_FAILURE
192-
- 160: COAP code 5.00
193-
194-
```bash
195-
> bbr mgmt dua 1 2f7c235e5025a2fd
196-
Done
197-
> bbr mgmt dua 160
198-
Done
199-
```
200-
201176
### bbr mgmt mlr listener
202177

203178
Show the Multicast Listeners.
@@ -1959,34 +1934,6 @@ Set the Thread Domain Name for Thread 1.2 device.
19591934
Done
19601935
```
19611936
1962-
### dua iid
1963-
1964-
Get the Interface Identifier manually specified for Thread Domain Unicast Address on Thread 1.2 device.
1965-
1966-
```bash
1967-
> dua iid
1968-
0004000300020001
1969-
Done
1970-
```
1971-
1972-
### dua iid \<iid\>
1973-
1974-
Set the Interface Identifier manually specified for Thread Domain Unicast Address on Thread 1.2 device.
1975-
1976-
```bash
1977-
> dua iid 0004000300020001
1978-
Done
1979-
```
1980-
1981-
### dua iid clear
1982-
1983-
Clear the Interface Identifier manually specified for Thread Domain Unicast Address on Thread 1.2 device.
1984-
1985-
```bash
1986-
> dua iid clear
1987-
Done
1988-
```
1989-
19901937
### eidcache
19911938
19921939
Print the EID-to-RLOC cache entries.

src/core/BUILD.gn

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -690,8 +690,6 @@ openthread_core_files = [
690690
"thread/csl_tx_scheduler.hpp",
691691
"thread/discover_scanner.cpp",
692692
"thread/discover_scanner.hpp",
693-
"thread/dua_manager.cpp",
694-
"thread/dua_manager.hpp",
695693
"thread/energy_scan_server.cpp",
696694
"thread/energy_scan_server.hpp",
697695
"thread/indirect_sender.cpp",

src/core/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,6 @@ set(COMMON_SOURCES
237237
thread/child_table.cpp
238238
thread/csl_tx_scheduler.cpp
239239
thread/discover_scanner.cpp
240-
thread/dua_manager.cpp
241240
thread/energy_scan_server.cpp
242241
thread/indirect_sender.cpp
243242
thread/key_manager.cpp

src/core/backbone_router/bbr_leader.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -208,10 +208,6 @@ void Leader::UpdateBackboneRouterPrimary(void)
208208
Get<Mlr::Manager>().HandleBackboneRouterPrimaryUpdate(event);
209209
#endif
210210

211-
#if OPENTHREAD_FTD && OPENTHREAD_CONFIG_TMF_PROXY_DUA_ENABLE
212-
Get<DuaManager>().HandleBackboneRouterPrimaryUpdate(event);
213-
#endif
214-
215211
exit:
216212
OT_UNUSED_VARIABLE(event);
217213
}
@@ -253,10 +249,6 @@ void Leader::UpdateDomainPrefixConfig(void)
253249
Get<Local>().HandleDomainPrefixUpdate(event);
254250
#endif
255251

256-
#if OPENTHREAD_FTD && OPENTHREAD_CONFIG_TMF_PROXY_DUA_ENABLE
257-
Get<DuaManager>().HandleDomainPrefixUpdate(event);
258-
#endif
259-
260252
exit:
261253
OT_UNUSED_VARIABLE(event);
262254
}

src/core/backbone_router/bbr_manager.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
#include "common/locator.hpp"
4848
#include "common/non_copyable.hpp"
4949
#include "net/netif.hpp"
50-
#include "thread/dua_manager.hpp"
5150
#include "thread/mlr_types.hpp"
5251
#include "thread/network_data.hpp"
5352
#include "thread/tmf.hpp"

src/core/common/notifier.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,9 +143,6 @@ void Notifier::EmitEvents(void)
143143
#if OPENTHREAD_CONFIG_MLR_ENABLE || (OPENTHREAD_FTD && OPENTHREAD_CONFIG_TMF_PROXY_MLR_ENABLE)
144144
Get<Mlr::Manager>().HandleNotifierEvents(events);
145145
#endif
146-
#if OPENTHREAD_FTD && OPENTHREAD_CONFIG_TMF_PROXY_DUA_ENABLE
147-
Get<DuaManager>().HandleNotifierEvents(events);
148-
#endif
149146
#if OPENTHREAD_CONFIG_RADIO_LINK_TREL_ENABLE
150147
Get<Trel::Link>().HandleNotifierEvents(events);
151148
#endif

src/core/common/time_ticker.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -104,13 +104,6 @@ void TimeTicker::HandleTimer(void)
104104
}
105105
#endif
106106

107-
#if OPENTHREAD_FTD && OPENTHREAD_CONFIG_TMF_PROXY_DUA_ENABLE
108-
if (mReceivers & Mask(kDuaManager))
109-
{
110-
Get<DuaManager>().HandleTimeTick();
111-
}
112-
#endif
113-
114107
if (mReceivers & Mask(kIp6Mpl))
115108
{
116109
Get<Ip6::Mpl>().HandleTimeTick();

src/core/common/time_ticker.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ class TimeTicker : public InstanceLocator, private NonCopyable
6666
kAddressResolver, ///< `AddressResolver`
6767
kChildSupervisor, ///< `ChildSupervisor`
6868
kIp6FragmentReassembler, ///< `Ip6::Ip6` (handling of fragmented messages)
69-
kDuaManager, ///< `DuaManager`
7069
kNetworkDataNotifier, ///< `NetworkData::Notifier`
7170
kIp6Mpl, ///< `Ip6::Mpl`
7271
kBbrLocal, ///< `BackboneRouter::Local`

0 commit comments

Comments
 (0)