Skip to content

Commit 10c0173

Browse files
committed
fix: display one generic notification
Before this fix, if there were multiple hints matches, there would be multiple notifications
1 parent 011fb6c commit 10c0173

File tree

1 file changed

+15
-8
lines changed

1 file changed

+15
-8
lines changed

src/extension.ts

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3857,17 +3857,22 @@ export async function activate(context: vscode.ExtensionContext) {
38573857
return;
38583858
}
38593859

3860-
// Process the first error if available
3861-
const errorMsg = espIdfDiagnostics[0].diagnostic.message;
3862-
const foundHint = await treeDataProvider.searchError(
3863-
errorMsg,
3864-
workspaceRoot
3865-
);
3860+
// Process all errors and collect hints
3861+
let foundAnyHint = false;
3862+
for (const { diagnostic } of espIdfDiagnostics) {
3863+
const foundHint = await treeDataProvider.searchError(
3864+
diagnostic.message,
3865+
workspaceRoot
3866+
);
3867+
if (foundHint) {
3868+
foundAnyHint = true;
3869+
}
3870+
}
38663871

38673872
const showHintsNotification = context.workspaceState.get(
38683873
"idf.showHintsNotification"
38693874
);
3870-
if (foundHint && showHintsNotification) {
3875+
if (foundAnyHint && showHintsNotification) {
38713876
const actions = [
38723877
{
38733878
label: vscode.l10n.t("💡 Show Hints"),
@@ -3887,7 +3892,9 @@ export async function activate(context: vscode.ExtensionContext) {
38873892
];
38883893

38893894
await showInfoNotificationWithMultipleActions(
3890-
vscode.l10n.t(`Possible hint found for the error: {0}`, errorMsg),
3895+
vscode.l10n.t(
3896+
`Possible hints found for build errors. Click to view details.`
3897+
),
38913898
actions
38923899
);
38933900
}

0 commit comments

Comments
 (0)