refactor: integrate hints status bar item with main status bar system

- Move hints status bar creation to createCmdsStatusBarItems function
- Change id from "idfErrorHints" to "espIdf.errorHints"
- Use "registerIDFCommand" instead of "vscode.commands.registerCommand"

Author: radurentea

package.json

@@ -312,9 +312,9 @@
     "views": {
       "espIdfHints": [
         {
-          "id": "idfErrorHints",
+          "id": "espIdf.errorHints",
           "name": "%view.idf.errorHints%",
-          "title": "%view.idf.errorHints% ($idfErrorHints.count$)"
+          "title": "%view.idf.errorHints% ($espIdf.errorHints.count$)"
         }
       ],
       "debug": [
@@ -402,13 +402,13 @@
       "view/title": [
         {
           "command": "espIdf.errorHints.clearAll",
-          "when": "view == idfErrorHints",
+          "when": "view == espIdf.errorHints",
           "group": "navigation"
         },
         {
           "command": "espIdf.searchError",
           "group": "navigation",
-          "when": "view == idfErrorHints"
+          "when": "view == espIdf.errorHints"
         },
         {
           "command": "espIdf.partition.table.refresh",
@@ -458,11 +458,11 @@
       "view/item/context": [
         {
           "command": "espIdf.errorHints.clearBuildErrors",
-          "when": "view == idfErrorHints && viewItem == buildError"
+          "when": "view == espIdf.errorHints && viewItem == buildError"
         },
         {
           "command": "espIdf.errorHints.clearOpenOCDErrors",
-          "when": "view == idfErrorHints && viewItem == openocdError"
+          "when": "view == espIdf.errorHints && viewItem == openocdError"
         },
         {
           "command": "esp.rainmaker.backend.logout",

src/extension.ts

@@ -183,10 +183,7 @@ import {
 } from "./cdtDebugAdapter/hexViewProvider";
 import { configureClangSettings } from "./clang";
 import { OpenOCDErrorMonitor } from "./espIdf/hints/openocdhint";
-import {
-  createHintsStatusBarItem,
-  updateHintsStatusBarItem,
-} from "./statusBar";
+import { updateHintsStatusBarItem } from "./statusBar";
 
 // Global variables shared by commands
 let workspaceRoot: vscode.Uri;
@@ -3657,7 +3654,7 @@ export async function activate(context: vscode.ExtensionContext) {
   if (PreCheck.isWorkspaceFolderOpen()) {
     const treeDataProvider = new ErrorHintProvider(context);
 
-    const treeView = vscode.window.createTreeView("idfErrorHints", {
+    const treeView = vscode.window.createTreeView("espIdf.errorHints", {
       treeDataProvider: treeDataProvider,
       showCollapseAll: true,
     });
@@ -3668,26 +3665,20 @@ export async function activate(context: vscode.ExtensionContext) {
     context.subscriptions.push(treeView);
 
     // Register commands for clearing error hints
-    vscode.commands.registerCommand("espIdf.errorHints.clearAll", () => {
+    registerIDFCommand("espIdf.errorHints.clearAll", () => {
       treeDataProvider.clearErrorHints(true); // Clear both build and OpenOCD errors
       updateHintsStatusBarItem(false);
     });
 
-    vscode.commands.registerCommand(
-      "espIdf.errorHints.clearBuildErrors",
-      () => {
-        treeDataProvider.clearErrorHints(false); // Clear only build errors
-        updateHintsStatusBarItem(false);
-      }
-    );
+    registerIDFCommand("espIdf.errorHints.clearBuildErrors", () => {
+      treeDataProvider.clearErrorHints(false); // Clear only build errors
+      updateHintsStatusBarItem(false);
+    });
 
-    vscode.commands.registerCommand(
-      "espIdf.errorHints.clearOpenOCDErrors",
-      () => {
-        treeDataProvider.clearOpenOCDErrorsOnly(); // Clear only OpenOCD errors
-        updateHintsStatusBarItem(false);
-      }
-    );
+    registerIDFCommand("espIdf.errorHints.clearOpenOCDErrors", () => {
+      treeDataProvider.clearOpenOCDErrorsOnly(); // Clear only OpenOCD errors
+      updateHintsStatusBarItem(false);
+    });
 
     const openOCDErrorMonitor = OpenOCDErrorMonitor.init(
       treeDataProvider,
@@ -3703,13 +3694,13 @@ export async function activate(context: vscode.ExtensionContext) {
     });
 
     // Register command to manually search for errors
-    vscode.commands.registerCommand("espIdf.searchError", async () => {
+    registerIDFCommand("espIdf.searchError", async () => {
       const errorMsg = await vscode.window.showInputBox({
         placeHolder: "Enter the error message",
       });
       if (errorMsg) {
         treeDataProvider.searchError(errorMsg, workspaceRoot);
-        await vscode.commands.executeCommand("idfErrorHints.focus");
+        await vscode.commands.executeCommand("espIdf.errorHints.focus");
       }
     });
 
@@ -3759,10 +3750,6 @@ export async function activate(context: vscode.ExtensionContext) {
       )
     );
 
-    // --- Hints Status Bar Item ---
-    const hintsStatusBarItem = createHintsStatusBarItem();
-    context.subscriptions.push(hintsStatusBarItem);
-
     // Subscribe to changes in the hints tree and update the status bar item
     treeDataProvider.onDidChangeTreeData(() => {
       updateHintsStatusBarItem(treeDataProvider.hasHints());

src/statusBar/index.ts

@@ -236,6 +236,14 @@ export async function createCmdsStatusBarItems(workspaceFolder: Uri) {
     89,
     commandDictionary[CommandKeys.CustomTask].checkboxState
   );
+  statusBarItems["hints"] = createStatusBarItem(
+    l10n.t("💡 New ESP-IDF Hints!"),
+    l10n.t("ESP-IDF: Hints available. Click to view."),
+    "espIdf.errorHints.focus",
+    1000,
+    TreeItemCheckboxState.Unchecked
+  );
+  statusBarItems["hints"].hide();
   return statusBarItems;
 }
 
@@ -258,49 +266,31 @@ export function createStatusBarItem(
   return statusBarItem;
 }
 
-// --- ESP-IDF Hints Status Bar Item ---
-let hintsStatusBarItem: StatusBarItem | undefined;
-
-/**
- * Create the ESP-IDF Hints status bar item using createStatusBarItem
- */
-export function createHintsStatusBarItem() {
-  if (!hintsStatusBarItem) {
-    hintsStatusBarItem = createStatusBarItem(
-      l10n.t("💡 New ESP-IDF Hints!"),
-      l10n.t("ESP-IDF: Hints available. Click to view."),
-      "idfErrorHints.focus",
-      1000, // Highest priority to appear first
-      TreeItemCheckboxState.Checked
-    );
-    hintsStatusBarItem.hide(); // Hide by default until hints are available
-  }
-  return hintsStatusBarItem;
-}
-
 /**
  * Show the hints status bar item with an alert icon if hints are available
  * @param {boolean} hasHints - Whether hints are available
  */
 export function updateHintsStatusBarItem(hasHints: boolean) {
-  if (!hintsStatusBarItem) return;
+  if (!statusBarItems["hints"]) return;
   if (hasHints) {
-    hintsStatusBarItem.text = l10n.t("💡 New ESP-IDF Hints!");
-    hintsStatusBarItem.tooltip = l10n.t("ESP-IDF: Hints available. Click to view.");
-    hintsStatusBarItem.backgroundColor = "statusBarItem.warningBackground";
-    hintsStatusBarItem.show();
+    statusBarItems["hints"].text = l10n.t("💡 New ESP-IDF Hints!");
+    statusBarItems["hints"].tooltip = l10n.t(
+      "ESP-IDF: Hints available. Click to view."
+    );
+    statusBarItems["hints"].backgroundColor = "statusBarItem.warningBackground";
+    statusBarItems["hints"].show();
   } else {
-    hintsStatusBarItem.hide();
-    hintsStatusBarItem.color = undefined;
+    statusBarItems["hints"].hide();
+    statusBarItems["hints"].color = undefined;
   }
 }
 
 /**
  * Dispose the hints status bar item
  */
 export function disposeHintsStatusBarItem() {
-  if (hintsStatusBarItem) {
-    hintsStatusBarItem.dispose();
-    hintsStatusBarItem = undefined;
+  if (statusBarItems["hints"]) {
+    statusBarItems["hints"].dispose();
+    statusBarItems["hints"] = undefined;
   }
 }