Skip to content

Commit db67a46

Browse files
Release/1.5.0 (#781)
* add changelog for v1.5.0 * add issue report * fix esp matter add workspace to read conf settings * fix lint
1 parent 8e27a28 commit db67a46

File tree

5 files changed

+152
-73
lines changed

5 files changed

+152
-73
lines changed
Lines changed: 99 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,99 @@
1+
name: Issue report
2+
description: Report any issue here
3+
labels: ["bug-report"]
4+
body:
5+
- type: markdown
6+
attributes:
7+
value: |
8+
* Before reporting a new issue please check and search in [List of existing issues](https://github.com/espressif/vscode-esp-idf-extension/issues?q=is%3Aissue)
9+
* Please check [Online Documentation](https://github.com/espressif/vscode-esp-idf-extension/blob/master/docs/ONBOARDING.md)
10+
* Take a look on [Troubleshooting guide](https://github.com/espressif/vscode-esp-idf-extension#troubleshooting)
11+
* If still experiencing the issue, please provide as many details as possible below about your hardware, computer setup and code.
12+
- type: dropdown
13+
id: os
14+
attributes:
15+
label: OS
16+
description: On which Operating System does the problem occurs?
17+
options:
18+
- Windows
19+
- MacOS
20+
- Linux
21+
validations:
22+
required: true
23+
- type: input
24+
id: osver
25+
attributes:
26+
label: Operating System version
27+
description: On which OS version this issue occur?
28+
placeholder: ex. macOS 12.1, Windows 10...
29+
validations:
30+
required: true
31+
- type: input
32+
id: vscodeversion
33+
attributes:
34+
label: Visual Studio Code version
35+
description: What Visual Studio Code version are you using
36+
placeholder: 1.35.1
37+
- type: input
38+
id: espidf
39+
attributes:
40+
label: ESP-IDF version
41+
description: What ESP-IDF version
42+
placeholder: 4.4.3
43+
validations:
44+
required: true
45+
- type: input
46+
id: pythonversion
47+
attributes:
48+
label: Python version
49+
description: What Python version are you using ?
50+
placeholder: 3.8.7
51+
validations:
52+
required: true
53+
- type: textarea
54+
id: doctorcmd
55+
attributes:
56+
label: Doctor command output
57+
description: What is the output of the 'ESP-IDF Doctor command' command?
58+
placeholder: ex. DevKitC, plain module on breadboard, etc. If your hardware is custom or unusual, please attach a photo.
59+
validations:
60+
required: true
61+
- type: textarea
62+
id: extensionlog
63+
attributes:
64+
label: Extension
65+
description: |
66+
Please share related content of extension log file located in:
67+
* Windows (%USERPROFILE%\.vscode\extensions\espressif.esp-idf-extension-VERSION\esp_idf_vsc_ext.log)
68+
* Linux-MacOS ($HOME/.vscode/extensions/espressif.esp-idf-extension-VERSION/esp_idf_vsc_ext.log)
69+
- type: textarea
70+
id: Description
71+
attributes:
72+
label: Description
73+
description: Please describe your problem here and expected behaviour
74+
placeholder: ex. Can't connect/weird behaviour/wrong function/missing parameter..
75+
validations:
76+
required: true
77+
- type: textarea
78+
id: Debug
79+
attributes:
80+
label: Debug Message
81+
description: Please provide a debug message or error message. If you have a Guru Meditation Error or Backtrace, please decode it with [ExceptionDecoder](https://github.com/me-no-dev/EspExceptionDecoder)
82+
placeholder: Set logLevel > 3 in launch.json for Debug errors and idf.openOcdDebugLevel > 3 for OpenOCD output
83+
render: plain
84+
validations:
85+
required: true
86+
- type: textarea
87+
id: other-remarks
88+
attributes:
89+
label: Other Steps to Reproduce
90+
description: Is there any other information you can think of which will help us reproduce this problem? Any additional info can be added as well.
91+
placeholder: ex. I also tried on other OS, HW...it works correctly on that setup.
92+
- type: checkboxes
93+
id: confirmation
94+
attributes:
95+
label: I have checked existing issues, online documentation and the Troubleshooting Guide
96+
description: You agree to check all the resources above before opening a new issue.
97+
options:
98+
- label: I confirm I have checked existing issues, online documentation and Troubleshooting guide.
99+
required: true

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 0 additions & 64 deletions
This file was deleted.

CHANGELOG.md

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,48 @@
1717

1818
All notable changes to the "Espressif IDF" extension will be documented in this file.
1919

20+
## [1.5.0](https://github.com/espressif/vscode-esp-idf-extension/releases/tag/v1.5.0)
21+
22+
### Features and enhancements
23+
24+
- [Disassembly view](https://github.com/espressif/vscode-esp-idf-extension/pull/670)
25+
- [Customize build folder directory](https://github.com/espressif/vscode-esp-idf-extension/pull/668)
26+
- [Add unit test for getGcovExecutable function](https://github.com/espressif/vscode-esp-idf-extension/commit/9e4ca9c509af2f1a020def50370e305d4aa623d1)
27+
- [Docker container tutorial for the extension](https://github.com/espressif/vscode-esp-idf-extension/pull/693) Thanks @xiaolongba !
28+
- [Use esp-idf constraints file for python packages](https://github.com/espressif/vscode-esp-idf-extension/pull/700)
29+
- [Add esp32s3 default board](https://github.com/espressif/vscode-esp-idf-extension/pull/724)
30+
- [Remove powershell wrapper for WSL](https://github.com/espressif/vscode-esp-idf-extension/pull/734)
31+
- [Add C Code in Disassembly view](https://github.com/espressif/vscode-esp-idf-extension/pull/741)
32+
- [Unified ESP-IDF Output channel](https://github.com/espressif/vscode-esp-idf-extension/pull/716)
33+
- [Add ESP-Matter framework support](https://github.com/espressif/vscode-esp-idf-extension/pull/547)
34+
- [Add ESP-IDF tags for older ESP-IDF versions download in Setup Wizard](https://github.com/espressif/vscode-esp-idf-extension/pull/747)
35+
- [Add DFU documentation](https://github.com/espressif/vscode-esp-idf-extension/pull/752)
36+
- [Add existing project tutorial](https://github.com/espressif/vscode-esp-idf-extension/pull/771)
37+
- [Add preview targets support in idf.py set-target](https://github.com/espressif/vscode-esp-idf-extension/pull/767)
38+
- [Peripheral Register view](https://github.com/espressif/vscode-esp-idf-extension/pull/755)
39+
- [Add custom openOCD server launch arguments](https://github.com/espressif/vscode-esp-idf-extension/pull/777)
40+
41+
### Bug Fixes
42+
43+
- [Fix port on status bar](https://github.com/espressif/vscode-esp-idf-extension/pull/662)
44+
- [Clean terminal output before build task](https://github.com/espressif/vscode-esp-idf-extension/pull/692)
45+
- [Fix release branch option to use git clone](https://github.com/espressif/vscode-esp-idf-extension/pull/696)
46+
- [Fix write configuration settings to use current workspace](https://github.com/espressif/vscode-esp-idf-extension/pull/701)
47+
- [Fix no-stub esptool flash argument](https://github.com/espressif/vscode-esp-idf-extension/pull/702)
48+
- [Close IDF Monitor before erase flash task](https://github.com/espressif/vscode-esp-idf-extension/pull/705)
49+
- [Add encrypt and refactor to single flash command](https://github.com/espressif/vscode-esp-idf-extension/pull/719)
50+
- [Fix partition table explorer issues](https://github.com/espressif/vscode-esp-idf-extension/pull/726) Thanks @boarchuz !
51+
- [Fix doc link for project creation template](https://github.com/espressif/vscode-esp-idf-extension/pull/729) Thanks @hassandraga !
52+
- [Fix pythonBinPath in DFU Flashing](https://github.com/espressif/vscode-esp-idf-extension/pull/740)
53+
- [Add idf.gitPathWin to avoid WSL issues](https://github.com/espressif/vscode-esp-idf-extension/pull/737)
54+
- [Add spiffs and fat as partition table data subtypes](https://github.com/espressif/vscode-esp-idf-extension/pull/745)
55+
- [Fix problem matcher regex for tasks](https://github.com/espressif/vscode-esp-idf-extension/pull/749)
56+
- [Add space validation in Setup Wizard](https://github.com/espressif/vscode-esp-idf-extension/pull/761)
57+
- [Fix doctor command core python requirements](https://github.com/espressif/vscode-esp-idf-extension/pull/766)
58+
- [Fix tar xz extraction](https://github.com/espressif/vscode-esp-idf-extension/pull/776)
59+
- [Update problem matcher regex](https://github.com/espressif/vscode-esp-idf-extension/pull/779)
60+
- [Update Pull request template](https://github.com/espressif/vscode-esp-idf-extension/pull/753)
61+
2062
## [1.4.0](https://github.com/espressif/vscode-esp-idf-extension/releases/tag/v1.4.0)
2163

2264
### Features and enhancements

src/espMatter/espMatterDownload.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import {
2424
TaskPresentationOptions,
2525
TaskRevealKind,
2626
TaskScope,
27+
Uri,
2728
} from "vscode";
2829
import { AbstractCloning } from "../common/abstractCloning";
2930
import { readParameter } from "../idfConfiguration";
@@ -32,8 +33,7 @@ import { TaskManager } from "../taskManager";
3233

3334
export class EspMatterCloning extends AbstractCloning {
3435
public static isBuildingGn: boolean;
35-
public currWorkspace: string;
36-
constructor(gitBinPath: string = "git") {
36+
constructor(gitBinPath: string = "git", public currWorkspace: Uri) {
3737
super(
3838
"https://github.com/espressif/esp-matter.git",
3939
"ESP-MATTER",
@@ -53,7 +53,7 @@ export class EspMatterCloning extends AbstractCloning {
5353
if (EspMatterCloning.isBuildingGn) {
5454
throw new Error("ALREADY_BUILDING");
5555
}
56-
const matterPathDir = readParameter("idf.espMatterPath");
56+
const matterPathDir = readParameter("idf.espMatterPath", this.currWorkspace);
5757
const espMatterPathExists = await pathExists(matterPathDir);
5858
if (!espMatterPathExists) {
5959
return;
@@ -73,7 +73,7 @@ export class EspMatterCloning extends AbstractCloning {
7373
cwd: workingDir,
7474
};
7575
const buildGnExec = this.getShellExecution(bootstrapFilePath, shellOptions);
76-
const isSilentMode = readParameter("idf.notificationSilentMode");
76+
const isSilentMode = readParameter("idf.notificationSilentMode", this.currWorkspace);
7777
const showTaskOutput = isSilentMode
7878
? TaskRevealKind.Always
7979
: TaskRevealKind.Silent;
@@ -100,11 +100,11 @@ export class EspMatterCloning extends AbstractCloning {
100100
}
101101
}
102102

103-
export async function getEspMatter() {
104-
const gitPath = (await readParameter("idf.gitPath")) || "/usr/bin/git";
105-
const espMatterInstaller = new EspMatterCloning(gitPath);
103+
export async function getEspMatter(workspace?: Uri) {
104+
const gitPath = (await readParameter("idf.gitPath", workspace)) || "/usr/bin/git";
105+
const espMatterInstaller = new EspMatterCloning(gitPath, workspace);
106106
try {
107-
await espMatterInstaller.getRepository("idf.espMatterPath");
107+
await espMatterInstaller.getRepository("idf.espMatterPath", workspace);
108108
await espMatterInstaller.startBootstrap();
109109
await TaskManager.runTasks();
110110
EspMatterCloning.isBuildingGn = false;

src/extension.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -686,7 +686,9 @@ export async function activate(context: vscode.ExtensionContext) {
686686

687687
registerIDFCommand("espIdf.getEspMdf", async () => getEspMdf(workspaceRoot));
688688

689-
registerIDFCommand("espIdf.getEspMatter", getEspMatter);
689+
registerIDFCommand("espIdf.getEspMatter", async () =>
690+
getEspMatter(workspaceRoot)
691+
);
690692

691693
registerIDFCommand("espIdf.selectPort", () => {
692694
PreCheck.perform([webIdeCheck, openFolderCheck], async () =>

0 commit comments

Comments
 (0)