Skip to content

Conversation

@brianignacio5
Copy link
Collaborator

Description

Replace user HOME path with for doctor command log file output.

Fixes #1496

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "ESP-IDF: Doctor Command" from command palette.
  2. Execute action.
  3. Observe results. The log file section should show instead of the user HOME path.
  • Expected behaviour:
    The log file section should show instead of the user HOME path.

  • Expected output:
    The log file section should show instead of the user HOME path.

How has this been tested?

Steps as described above.

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added this to the v1.11.0 milestone Apr 21, 2025
@brianignacio5 brianignacio5 self-assigned this Apr 21, 2025
@github-actions
Copy link

github-actions bot commented Apr 21, 2025

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianignacio5 brianignacio5 changed the title add HOMEPATH to log file ouput in doctor command add HOMEPATH to log file output in doctor command Apr 22, 2025
@Fabricio-ESP Fabricio-ESP changed the title add HOMEPATH to log file output in doctor command [VSC-1639] add HOMEPATH to log file output in doctor command May 7, 2025
Copy link
Collaborator

@Fabricio-ESP Fabricio-ESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed no home folder printed on the doctor command.

@brianignacio5 brianignacio5 merged commit ee180ec into master May 12, 2025
6 checks passed
@brianignacio5 brianignacio5 deleted the bugfix/log-homepath branch May 12, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ESP-IDF Doctor doesn't strip HOMEPATH from logfile (VSC-1639)

4 participants