Skip to content

Conversation

@brianignacio5
Copy link
Collaborator

Description

Update disassembly view request code to match latest DAP protocol and Eclipse CDT debug adapter implementation.

Fixes #1399

Type of change

  • New feature (non-breaking change which adds functionality)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Start a debug session on a ESP-IDF project. Right click and select Open Disassembly view
  2. Execute action.
  3. Observe results.
  • Expected behaviour:
    The resulting code for assembly should match better with original C code.

  • Expected output:

How has this been tested?

Manual testing as described above.

Test Configuration:

  • ESP-IDF Version: 5.4.1
  • OS (Windows,Linux and macOS): MacOS

Dependent components impacted by this PR:

  • Eclipse CDT Debug Adapter fork

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Apr 21, 2025
@brianignacio5 brianignacio5 added this to the v1.11.0 milestone Apr 21, 2025
@github-actions
Copy link

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

@brianignacio5 brianignacio5 added the enhancement New feature or request label Apr 21, 2025
Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fabricio-ESP Fabricio-ESP changed the title add disassembly view updates [VSC-1557] add disassembly view updates May 7, 2025
Copy link
Collaborator

@Fabricio-ESP Fabricio-ESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed debug is in sync now.

@brianignacio5 brianignacio5 merged commit 47fb8b9 into master May 8, 2025
6 checks passed
@brianignacio5 brianignacio5 deleted the enhance/disassembly-view-updates branch May 8, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visual Studio Disassembly view out of sync (VSC-1557)

4 participants