Skip to content

Conversation

@brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Apr 27, 2025

Description

Add quick pick functionality with currently selected option.

Fixes #1524
Fixes #1543

Type of change

  • New feature (non-breaking change which adds functionality)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "ESP-IDF: Select OpenOCD Configuration"
  2. Execute action. The currently selected OpenOCD board should be highlighted.
  3. Observe results.
  • Expected behaviour:
    The currently selected OpenOCD board should be highlighted.

  • Expected output:

How has this been tested?

Manual testing with steps above.

Test Configuration:

  • ESP-IDF Version: 5.1.6
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added this to the v1.11.0 milestone Apr 27, 2025
@brianignacio5 brianignacio5 self-assigned this Apr 27, 2025
@github-actions
Copy link

github-actions bot commented Apr 27, 2025

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

@Fabricio-ESP Fabricio-ESP changed the title use createQuickPick for openocd board to show currently active item. [VSC-1661] use createQuickPick for openocd board to show currently active item. May 7, 2025
@brianignacio5 brianignacio5 force-pushed the enhance/quickPickWithSelectedItem branch from 6964bfb to 33de67a Compare May 12, 2025 07:05
@Fabricio-ESP Fabricio-ESP self-requested a review May 12, 2025 08:59
@brianignacio5 brianignacio5 requested a review from radurentea May 12, 2025 09:00
Copy link
Collaborator

@Fabricio-ESP Fabricio-ESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working.
Settings.json updated successfully.
Selected board highlighted on the drop down menu.

Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianignacio5 brianignacio5 merged commit 7d6e95d into master May 12, 2025
6 checks passed
@brianignacio5 brianignacio5 changed the title [VSC-1661] use createQuickPick for openocd board to show currently active item. [VSC-1661 VSC-1675] use createQuickPick for openocd board to show currently active item. May 12, 2025
@brianignacio5 brianignacio5 deleted the enhance/quickPickWithSelectedItem branch May 12, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AppData settings.json cross-contamination between projects (VSC-1675) [Feature Request]: show currently selected OpenOCD target (VSC-1661)

4 participants