-
Notifications
You must be signed in to change notification settings - Fork 335
Feature/add devkits support #1557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Download the artifacts for this pull request: |
|
Pull request has been marked as |
Fix Lint
Adds a check to verify that esp_detect_config.py exists before attempting to run it. This prevents potential errors when the script is missing and provides clearer error messages to users
6d03233 to
aa3712c
Compare
4c79009 to
6746806
Compare
brianignacio5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
An small thing, in setTargetInIDF.ts we should add a line before spawn (line 78) to print something in OutputChannel (OutputChannel.appendLine("Running IDF Set Target action", "Set Target"); for example) to add a separation between set-target output.
Right now the Detect OpenOCD Config tag is closing after set target output (because spawn also print in OutputChannel).
- Validation is hard to maintain and unnecessary if we validate based on existing "esp_detect_config.py" script
brianignacio5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fabricio-ESP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed successfully detecting connected devkits, and able to distinguish between multiple boards to run flash and debug over jtag.
Testes on windows11, MacOS15 and Ubuntu24
Description
With this new feature, when we set the device target, we will now run a script which will detect all the connected boards. In the background this will run OpenOCD, which will make showing the possible device target list a bit slower.
There are 2 validations happening:
<idf_tools_path>/tools/openocd-esp32/<version>/openocd-esp32/share/openocd/espressif/tools/esp_detect_config.pyexistsType of change
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
idf_tools_path>/tools/openocd-esp32/<version>/openocd-esp32/share/openocd/espressif/tools/esp_detect_config.pywith the one from openocd's master branchAnother scenario to test is: if the OpenOCD version is correct but the Python script fails (e.g., not found), the device target list needs to falls back to the previous implementation.
How has this been tested?
As described above.
Test Configuration:
Checklist