Skip to content

Conversation

@radurentea
Copy link
Collaborator

Description

Add .gitignore file when creating esp-idf projects

Fixes #1412

Type of change

  • New feature (non-breaking change which adds functionality)

Steps to test this pull request

Create a new esp-idf project. .gitignore should be added automatically with the content inside templates\.gitignore of this PR.

How has this been tested?

As described above

Test Configuration:

  • ESP-IDF Version: 5.4
  • OS (Windows,Linux and macOS): Windows

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@radurentea radurentea self-assigned this Jun 2, 2025
@github-actions
Copy link

github-actions bot commented Jun 2, 2025

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change to reduce code duplication.

@radurentea radurentea added this to the v1.11.0 milestone Jun 3, 2025
Added the code inside copyFromSrcProject
@radurentea radurentea requested a review from brianignacio5 June 4, 2025 13:35
@radurentea
Copy link
Collaborator Author

Small change to reduce code duplication.

Yes, you are right. I have changed the implementation.
Thank you!

@github-actions
Copy link

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Jun 20, 2025
@radurentea radurentea removed the stale Stale PR or Issue label Jun 20, 2025
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some unrelated changes in this PR that could cause unexpected behavior.

@radurentea radurentea requested a review from brianignacio5 July 2, 2025 10:51
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Fabricio-ESP Fabricio-ESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed gitignore file created from template successfully on new projects.

@radurentea radurentea merged commit 88c1c8d into master Jul 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Automatically Generate .gitignore for ESP-IDF Projects (VSC-1576)

4 participants