[VSC-1577] Fix for cloning dev branches #1584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For cloning I've also added tags containing "-dev" at the end From testing it seems that version retrieve the name without the file extension (e.g. it will retrieve "v5.5-dev" instead of "v5.5-dev.zip").
|
Download the artifacts for this pull request: |
3 tasks
Fabricio-ESP
approved these changes
Jun 10, 2025
Collaborator
Fabricio-ESP
left a comment
Fabricio-ESP
left a comment
There was a problem hiding this comment.
Confirmed installation of dev branch is correctly directed to git clone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When installing an ESP-IDF version, our extension supports two primary methods:
This fix extends support to development branches ending in "-dev" (e.g., v5.5-dev). Prior to this change, the extension would incorrectly attempt a zip file download for these versions, which are not provided. Now, -dev branches will be correctly installed via repository cloning.
Fixes #1577
Type of change
Please delete options that are not relevant.
Steps to test this pull request
Try to install the following version (make sure to have "Show all ESP-IDF Tags" ticked):
Should be tested for with stable and official releases as well.
How has this been tested?
As described above
Test Configuration:
Checklist