-
Notifications
You must be signed in to change notification settings - Fork 335
[VSC-1581] App trace update example and fix #1656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Download the artifacts for this pull request: |
erhankur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@radurentea thanks for fixing the guide and reset issue.
brianignacio5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with few suggestions.
|
Thank you for the reviews, I've made the modifications requested. @erhankur can you please take another look? |
- stop openocd automatically when app tracing is stopped. - remove workspaceFolder
Fabricio-ESP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working.
Description
This pull request updates the App Tracing feature documentation and removes parsing of app trace files, since the output coming from esp-idf changed. The changes focus on making the tracing functionality work with the new app_trace_basic example.
App Trace fix
run openocd -> reset target -> send commandDocumentation Improvements
app_trace_basicexample. [1].vscode/settings.jsonfor proper tracing functionality. [1]UI and Visual Improvements
ThemeIcon("pulse")for heap traces andThemeIcon("archive")for app traces in the trace archive tree view. [1]Trace Archive Management
Type of change
Please delete options that are not relevant.
Steps to test this pull request
Follow steps in app trace documentation and heap trace documentation.
Both app trace and heap trace should work.
App trace files should open inside editor when they get clicked in the "App Trace Archives", while heap trace should still open inside "IDF Tracing" webview
How has this been tested?
As explained above
Test Configuration:
Checklist