[VSC-1769] Bugfixes for v1.11.0 based on Telemetry #1675
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several improvements and refactors across the codebase, focusing mainly on platform detection, error logging, telemetry control, and code clarity. The most significant changes are the simplification of platform and architecture detection logic, enhanced control over error reporting to telemetry, and improved consistency in error handling throughout the project.
Platform detection and architecture handling:
PlatformInformation.GetPlatformInformation()to synchronously determine platform and architecture usingos.platform()andos.arch(), removing all asynchronous child process calls and mapping architectures directly. This simplifies platform detection and removes unnecessary complexity. [1] [2]PlatformInformation.GetPlatformInformation()throughout the codebase to reflect the new synchronous implementation. [1] [2] [3]Error logging and telemetry control:
sendToTelemetryoption to theISpawnOptionsinterface and integrated it into thespawnandLogger.errorNotifyfunctions, allowing fine-grained control over which errors are sent to telemetry. Updated related function calls to utilize this option. [1] [2] [3] [4] [5] [6] [7]General code improvements and bug fixes:
Tool management and validation:
IdfToolsManagerto verify if a binary is in the system path before attempting to retrieve its version, preventing unnecessary errors when tools are missing.Test and setup adjustments:
Fixes #XXX
Type of change
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
ESP-IDF: Configure ESP-IDF Extension. The setup should install tools corresponding to the current OS and architecture.Expected behaviour:
Expected output:
How has this been tested?
Manual test as above.
Test Configuration:
Checklist