Skip to content

VSC-1770 add constraint in pytest install step #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2025
Merged

VSC-1770 add constraint in pytest install step #1686

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07d28aa
add constraint in pytest install step
brianignacio5 Oct 13, 2025
3602ea2
fix issue with workspace folder
brianignacio5 Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions src/espIdf/unitTest/configure.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { ESP } from "../../config";
import { join } from "path";
import { copy, pathExists, readFile, writeFile } from "fs-extra";
import { readParameter, readSerialPort } from "../../idfConfiguration";
import { startPythonReqsProcess } from "../../utils";
import { getEspIdfFromCMake, startPythonReqsProcess } from "../../utils";
import { runTaskForCommand } from "./testExecution";
import { buildCommand } from "../../build/buildCmd";
import { verifyCanFlash } from "../../flash/flashCmd";
Expand All @@ -48,7 +48,10 @@ export async function configurePyTestUnitApp(
if (!doesUnitTestAppExists) {
const unitTestFiles = await getFileList();
const testComponents = await getTestComponents(unitTestFiles);
unitTestAppUri = await copyTestAppProject(workspaceFolder, testComponents);
unitTestAppUri = await copyTestAppProject(
workspaceFolder,
testComponents
);
await buildFlashTestApp(unitTestAppUri, cancelToken);
}
return unitTestAppUri;
Expand Down Expand Up @@ -132,6 +135,16 @@ export async function installPyTestPackages(
cancelToken?: CancellationToken
) {
const idfPath = readParameter("idf.espIdfPath", workspaceFolder);
const containerPath =
process.platform === "win32" ? process.env.USERPROFILE : process.env.HOME;
const confToolsPath = readParameter(
"idf.toolsPath",
workspaceFolder
) as string;
const toolsPath =
confToolsPath ||
process.env.IDF_TOOLS_PATH ||
join(containerPath, ".espressif");
const pythonBinPath = await getVirtualEnvPythonPath(workspaceFolder);
let requirementsPath = join(
idfPath,
Expand All @@ -148,9 +161,27 @@ export async function installPyTestPackages(
);
}

const fullEspIdfVersion = await getEspIdfFromCMake(idfPath);
const majorMinorMatches = fullEspIdfVersion.match(/([0-9]+\.[0-9]+).*/);
const espIdfVersion =
majorMinorMatches && majorMinorMatches.length > 0
? majorMinorMatches[1]
: "x.x";
const constrainsFile = join(
toolsPath,
`espidf.constraints.v${espIdfVersion}.txt`
);
const constrainsFileExists = await pathExists(constrainsFile);
let constraintArg = [];
if (constrainsFileExists) {
constraintArg = ["--constraint", constrainsFile];
}

await runTaskForCommand(
workspaceFolder,
`"${pythonBinPath}" -m pip install --upgrade --no-warn-script-location -r "${requirementsPath}" --extra-index-url https://dl.espressif.com/pypi`,
`"${pythonBinPath}" -m pip install --upgrade ${
constraintArg && constraintArg.length > 0 ? constraintArg.join(" ") : ""
} --no-warn-script-location -r "${requirementsPath}" --extra-index-url https://dl.espressif.com/pypi`,
"Install Pytest",
cancelToken
);
Expand Down