[VSC-1800] - OPENOCD_USB_ADAPTER_LOCATION not being cleared #1711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed the declaration of customExtraVars to a single location and added logic to clear OPENOCD_USB_ADAPTER_LOCATION when no board location is available or when switching to a non-connected target.
|
Download the artifacts for this pull request: |
Clear the OPENOCD_USB_ADAPTER_LOCATION setting when switching to a target that doesn't have a USB location, preventing OpenOCD from using stale device addresses from previous targets. Create a plain object copy of customExtraVars to avoid proxy issues when deleting properties, and remove unnecessary configuration re-read.
Collaborator
|
The thing about this logic is only applies when user run the setTarget command. I'm wondering for the case: 1) User has connected board, 2) Run set target, 3) value is set in customExtraVars 4) Time passes user disconnect board 5) User tries to use OpenOCD Server directly and it doesn't work ? USB_ADAPTER_LOCATION is changed ? |
Remove OPENOCD_USB_ADAPTER_LOCATION from environment during device detection so the script can scan all available devices, not just the one at the configured location.
- Added extra bool parameter for running openOCDManager.version() with default value false, for not silencing the output from it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved the declaration of customExtraVars to a single location and added logic to clear OPENOCD_USB_ADAPTER_LOCATION when no board location is available or when switching to a non-connected target.
Type of change
Please delete options that are not relevant.
Steps to test this pull request
The "OPENOCD_USB_ADAPTER_LOCATIO" property should be cleared from idf.customExtraVars and setting again the target to a connected board or using JTAG flashing should work.
How has this been tested?
Same as described above
Test Configuration:
Checklist