Skip to content

Commit 8611df9

Browse files
committed
source-google-sheets: add debug logs to troubleshoot missing "properties" field
1 parent 5adeef7 commit 8611df9

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

airbyte-integrations/connectors/source-google-sheets/google_sheets_source/google_sheets_source.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ def read(
134134
) -> Generator[AirbyteMessage, None, None]:
135135
client = GoogleSheetsClient(self.get_credentials(config))
136136

137-
sheet_to_column_name = Helpers.parse_sheet_and_column_names_from_catalog(catalog)
137+
sheet_to_column_name = Helpers.parse_sheet_and_column_names_from_catalog(catalog, logger)
138138
spreadsheet_id = Helpers.get_spreadsheet_id(config["spreadsheet_id"])
139139

140140
row_batch_size = config.get("row_batch_size", ROW_BATCH_SIZE)

airbyte-integrations/connectors/source-google-sheets/google_sheets_source/helpers.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,13 @@ def get_first_row(client, spreadsheet_id: str, sheet_name: str) -> List[str]:
119119
return Helpers.get_formatted_row_values(first_row_data)
120120

121121
@staticmethod
122-
def parse_sheet_and_column_names_from_catalog(catalog: ConfiguredAirbyteCatalog) -> Dict[str, FrozenSet[str]]:
122+
def parse_sheet_and_column_names_from_catalog(catalog: ConfiguredAirbyteCatalog, logger: AirbyteLogger) -> Dict[str, FrozenSet[str]]:
123123
sheet_to_column_name = {}
124+
logger.debug("Parsing sheet and column names from catalog.")
124125
for configured_stream in catalog.streams:
125126
stream = configured_stream.stream
126127
sheet_name = stream.name
128+
logger.debug(f"Attempting to parse sheet {sheet_name}. stream: {stream}, stream.json_schema: {stream.json_schema}")
127129
sheet_to_column_name[sheet_name] = frozenset(stream.json_schema["properties"].keys())
128130

129131
return sheet_to_column_name

airbyte-integrations/connectors/source-google-sheets/unit_tests/test_helpers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def test_parse_sheet_and_column_names_from_catalog(self):
145145
]
146146
)
147147

148-
actual = Helpers.parse_sheet_and_column_names_from_catalog(catalog)
148+
actual = Helpers.parse_sheet_and_column_names_from_catalog(catalog, logger)
149149

150150
expected = {sheet1: sheet1_columns, sheet2: sheet2_columns}
151151
self.assertEqual(actual, expected)

0 commit comments

Comments
 (0)