Skip to content

Commit 74fb3b5

Browse files
committed
estuary-cdk: make "form" the default client creds placement
1 parent 838c19d commit 74fb3b5

File tree

3 files changed

+26
-8
lines changed

3 files changed

+26
-8
lines changed

estuary-cdk/estuary_cdk/flow.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -210,9 +210,6 @@ class ResourceOwnerPasswordOAuth2Credentials(_BaseOAuth2CredentialsData):
210210

211211
class ClientCredentialsOAuth2Credentials(_BaseOAuth2CredentialsData):
212212
grant_type: ClassVar[str] = "client_credentials"
213-
client_credentials_placement: ClassVar[OAuth2ClientCredentialsPlacement] = (
214-
OAuth2ClientCredentialsPlacement.HEADERS
215-
)
216213

217214

218215
class AuthorizationCodeFlowOAuth2Credentials(

source-genesys/source_genesys/models.py

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,20 @@
11
from datetime import datetime, timezone, timedelta
22
from enum import StrEnum
33
from pydantic import AwareDatetime, BaseModel, Field
4-
from typing import ClassVar, Literal, Optional
4+
from typing import TYPE_CHECKING, ClassVar, Literal, Optional
55

66

77
from estuary_cdk.capture.common import (
88
BaseDocument,
99
ConnectorState as GenericConnectorState,
10-
ClientCredentialsOAuth2Credentials,
11-
OAuth2TokenFlowSpec,
1210
ResourceConfig,
1311
ResourceState,
1412
)
13+
from estuary_cdk.flow import (
14+
ClientCredentialsOAuth2Credentials,
15+
OAuth2ClientCredentialsPlacement,
16+
OAuth2TokenFlowSpec,
17+
)
1518

1619

1720
OAUTH2_SPEC = OAuth2TokenFlowSpec(
@@ -23,6 +26,14 @@
2326
}
2427
)
2528

29+
if TYPE_CHECKING:
30+
OAuth2Credentials = ClientCredentialsOAuth2Credentials
31+
else:
32+
OAuth2Credentials = (
33+
ClientCredentialsOAuth2Credentials.with_client_credentials_placement(
34+
OAuth2ClientCredentialsPlacement.HEADERS
35+
)
36+
)
2637

2738
def default_start_date():
2839
dt = datetime.now(timezone.utc) - timedelta(days=30)
@@ -54,7 +65,7 @@ class EndpointConfig(BaseModel):
5465
] = Field(
5566
title="Genesys Cloud Domain"
5667
)
57-
credentials: ClientCredentialsOAuth2Credentials = Field(
68+
credentials: OAuth2Credentials = Field(
5869
title="Authentication",
5970
discriminator="credentials_title"
6071
)

source-navan/source_navan/models.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from typing import (
2+
TYPE_CHECKING,
23
Generic,
34
TypeVar,
45
)
@@ -12,6 +13,7 @@
1213
)
1314
from estuary_cdk.flow import (
1415
ClientCredentialsOAuth2Credentials,
16+
OAuth2ClientCredentialsPlacement,
1517
OAuth2TokenFlowSpec,
1618
)
1719
from pydantic import (
@@ -28,9 +30,17 @@
2830
accessTokenResponseMap={"access_token": "/access_token"},
2931
)
3032

33+
if TYPE_CHECKING:
34+
OAuth2Credentials = ClientCredentialsOAuth2Credentials
35+
else:
36+
OAuth2Credentials = (
37+
ClientCredentialsOAuth2Credentials.with_client_credentials_placement(
38+
OAuth2ClientCredentialsPlacement.HEADERS
39+
)
40+
)
3141

3242
class EndpointConfig(BaseModel):
33-
credentials: ClientCredentialsOAuth2Credentials = Field(
43+
credentials: OAuth2Credentials = Field(
3444
title="Authentication",
3545
description="See https://app.navan.com/app/helpcenter/articles/travel/admin/other-integrations/booking-data-integration",
3646
)

0 commit comments

Comments
 (0)