Skip to content

Commit faa7be8

Browse files
committed
Fix ubuntu references in workflow yaml
1 parent 30f59c4 commit faa7be8

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

.github/workflows/flowctl-release.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,12 @@ jobs:
1717
fail-fast: false
1818
matrix:
1919
config:
20+
# Use the oldest ubuntu version because it'll have an old glibc. Programs built agains
21+
# an old glibc can link to a newer version, but not the other way around.
2022
- os: ubuntu-20.04
2123
assetName: flowctl-x86_64-linux
24+
# On mac, it's the opposite. Programs built on the latest macos can run on older versions,
25+
# but not the other way around.
2226
- os: macos-latest
2327
assetName: flowctl-multiarch-macos
2428
steps:
@@ -31,12 +35,12 @@ jobs:
3135

3236
# Linux build steps:
3337
- name: Install Rust
34-
if: matrix.config.os == 'ubuntu-latest'
38+
if: matrix.config.os == 'ubuntu-20.04'
3539
uses: actions-rs/toolchain@v1
3640
with:
3741
toolchain: stable
3842
- name: Build Linux
39-
if: matrix.config.os == 'ubuntu-latest'
43+
if: matrix.config.os == 'ubuntu-20.04'
4044
run: |-
4145
cargo build -p flowctl --release && mv target/release/flowctl ${ASSET_NAME}
4246

0 commit comments

Comments
 (0)