Skip to content

Commit f2b8cc1

Browse files
authored
Merge pull request Expensify#72696 from nyomanjyotisa/issue-72042
Fix: Split or incomplete translations in receipt
2 parents 3d46988 + 2264944 commit f2b8cc1

12 files changed

Lines changed: 13 additions & 44 deletions

File tree

src/CONST/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -987,7 +987,7 @@ const CONST = {
987987
IMPORT_TAGS_EXPENSIFY_URL_DEPENDENT_TAGS: 'https://help.expensify.com/articles/expensify-classic/workspaces/Create-tags#multi-level-tags',
988988
STAGING_EXPENSIFY_URL: 'https://staging.expensify.com',
989989
DENIED_CAMERA_ACCESS_INSTRUCTIONS_URL:
990-
'https://help.expensify.com/articles/new-expensify/expenses-&-payments/Create-an-expense#:~:text=How%20can%20I%20enable%20camera%20permission%20for%20a%20website%20on%20mobile%20browsers%3F',
990+
'https://help.expensify.com/articles/new-expensify/reports-and-expenses/Create-an-Expense#how-do-i-enable-camera-access-for-mobile-browsers-so-i-can-take-photos-of-my-receipts',
991991
BANK_ACCOUNT_PERSONAL_DOCUMENTATION_INFO_URL:
992992
'https://community.expensify.com/discussion/6983/faq-why-do-i-need-to-provide-personal-documentation-when-setting-up-updating-my-bank-account',
993993
PERSONAL_DATA_PROTECTION_INFO_URL: 'https://community.expensify.com/discussion/5677/deep-dive-security-how-expensify-protects-your-information',

src/languages/de.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1064,8 +1064,6 @@ const translations = {
10641064
dragReceiptsAfterEmail: 'oder wählen Sie Dateien zum Hochladen unten aus.',
10651065
desktopSubtitleSingle: `oder hierher ziehen und ablegen`,
10661066
desktopSubtitleMultiple: `oder hierher ziehen und ablegen`,
1067-
chooseReceipt: 'Wählen Sie eine Quittung zum Hochladen aus oder leiten Sie eine Quittung weiter an',
1068-
chooseReceipts: 'Wählen Sie Quittungen zum Hochladen aus oder leiten Sie Quittungen weiter an ',
10691067
alternativeMethodsTitle: 'Andere Möglichkeiten, Belege hinzuzufügen:',
10701068
alternativeMethodsDownloadApp: ({downloadUrl}: {downloadUrl: string}) => `<label-text><a href="${downloadUrl}">App herunterladen</a>, um mit Ihrem Telefon zu scannen</label-text>`,
10711069
alternativeMethodsForwardReceipts: ({email}: {email: string}) => `<label-text>Leiten Sie Belege an <a href="mailto:${email}">${email}</a> weiter</label-text>`,
@@ -1074,8 +1072,7 @@ const translations = {
10741072
alternativeMethodsTextReceipts: ({phoneNumber}: {phoneNumber: string}) => `<label-text>Senden Sie Belege per SMS an ${phoneNumber} (nur US-Nummern)</label-text>`,
10751073
takePhoto: 'Ein Foto machen',
10761074
cameraAccess: 'Der Kamerazugriff ist erforderlich, um Fotos von Belegen zu machen.',
1077-
deniedCameraAccess: 'Kamerazugriff wurde noch nicht gewährt, bitte folgen Sie',
1078-
deniedCameraAccessInstructions: 'diese Anweisungen',
1075+
deniedCameraAccess: `Kamerazugriff wurde noch nicht gewährt, bitte folgen Sie <a href="${CONST.DENIED_CAMERA_ACCESS_INSTRUCTIONS_URL}">diese Anweisungen</a>.`,
10791076
cameraErrorTitle: 'Kamerafehler',
10801077
cameraErrorMessage: 'Beim Aufnehmen eines Fotos ist ein Fehler aufgetreten. Bitte versuche es erneut.',
10811078
locationAccessTitle: 'Standortzugriff erlauben',

src/languages/en.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1046,8 +1046,6 @@ const translations = {
10461046
uploadMultiple: 'Upload receipts',
10471047
desktopSubtitleSingle: `or drag and drop it here`,
10481048
desktopSubtitleMultiple: `or drag and drop them here`,
1049-
chooseReceipt: 'Choose a receipt to upload or forward a receipt to ',
1050-
chooseReceipts: 'Choose receipts to upload or forward receipts to ',
10511049
alternativeMethodsTitle: 'Other ways to add receipts:',
10521050
alternativeMethodsDownloadApp: ({downloadUrl}: {downloadUrl: string}) => `<label-text><a href="${downloadUrl}">Download the app</a> to scan from your phone</label-text>`,
10531051
alternativeMethodsForwardReceipts: ({email}: {email: string}) => `<label-text>Forward receipts to <a href="mailto:${email}">${email}</a></label-text>`,
@@ -1056,8 +1054,7 @@ const translations = {
10561054
alternativeMethodsTextReceipts: ({phoneNumber}: {phoneNumber: string}) => `<label-text>Text receipts to ${phoneNumber} (US numbers only)</label-text>`,
10571055
takePhoto: 'Take a photo',
10581056
cameraAccess: 'Camera access is required to take pictures of receipts.',
1059-
deniedCameraAccess: "Camera access still hasn't been granted, please follow ",
1060-
deniedCameraAccessInstructions: 'these instructions',
1057+
deniedCameraAccess: `Camera access still hasn't been granted, please follow <a href="${CONST.DENIED_CAMERA_ACCESS_INSTRUCTIONS_URL}">these instructions</a>.`,
10611058
cameraErrorTitle: 'Camera error',
10621059
cameraErrorMessage: 'An error occurred while taking a photo. Please try again.',
10631060
locationAccessTitle: 'Allow location access',

src/languages/es.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1034,8 +1034,6 @@ const translations = {
10341034
uploadMultiple: 'Subir recibos',
10351035
desktopSubtitleSingle: 'o arrastra y suéltalo aquí',
10361036
desktopSubtitleMultiple: 'o arrástralos y suéltalos aquí',
1037-
chooseReceipt: 'Elige un recibo para subir o reenvía un recibo a ',
1038-
chooseReceipts: 'Elige recibos para subir o reenvía recibos a ',
10391037
alternativeMethodsTitle: 'Otras formas de añadir recibos:',
10401038
alternativeMethodsDownloadApp: ({downloadUrl}: {downloadUrl: string}) =>
10411039
`<label-text><a href="${downloadUrl}">Descarga la aplicación</a> para escanear desde tu teléfono</label-text>`,
@@ -1045,8 +1043,7 @@ const translations = {
10451043
alternativeMethodsTextReceipts: ({phoneNumber}: {phoneNumber: string}) => `<label-text>Envía recibos por SMS a ${phoneNumber} (solo números de EE.UU.)</label-text>`,
10461044
takePhoto: 'Haz una foto',
10471045
cameraAccess: 'Se requiere acceso a la cámara para hacer fotos de los recibos.',
1048-
deniedCameraAccess: 'No se ha concedido el acceso a la cámara, siga ',
1049-
deniedCameraAccessInstructions: 'estas instrucciones',
1046+
deniedCameraAccess: `No se ha concedido el acceso a la cámara, siga <a href="${CONST.DENIED_CAMERA_ACCESS_INSTRUCTIONS_URL}">estas instrucciones</a>.`,
10501047
cameraErrorTitle: 'Error en la cámara',
10511048
locationAccessTitle: 'Permitir acceso a la ubicación',
10521049
locationAccessMessage: 'El acceso a la ubicación nos ayuda a mantener tu zona horaria y moneda precisas dondequiera que vayas.',

src/languages/fr.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1060,8 +1060,6 @@ const translations = {
10601060
dragReceiptsAfterEmail: 'ou choisissez des fichiers à télécharger ci-dessous.',
10611061
desktopSubtitleSingle: `ou faites-le glisser ici`,
10621062
desktopSubtitleMultiple: `ou faites-les glisser ici`,
1063-
chooseReceipt: 'Choisissez un reçu à télécharger ou transférez un reçu à',
1064-
chooseReceipts: 'Choisissez des reçus à télécharger ou transférez des reçus à',
10651063
alternativeMethodsTitle: 'Autres façons d’ajouter des reçus :',
10661064
alternativeMethodsDownloadApp: ({downloadUrl}: {downloadUrl: string}) =>
10671065
`<label-text><a href="${downloadUrl}">Télécharger l’application</a> pour scanner depuis votre téléphone</label-text>`,
@@ -1071,8 +1069,7 @@ const translations = {
10711069
alternativeMethodsTextReceipts: ({phoneNumber}: {phoneNumber: string}) => `<label-text>Envoyez des reçus par SMS au ${phoneNumber} (numéros US uniquement)</label-text>`,
10721070
takePhoto: 'Prendre une photo',
10731071
cameraAccess: "L'accès à la caméra est requis pour prendre des photos des reçus.",
1074-
deniedCameraAccess: "L'accès à la caméra n'a toujours pas été accordé, veuillez suivre",
1075-
deniedCameraAccessInstructions: 'ces instructions',
1072+
deniedCameraAccess: `L'accès à la caméra n'a toujours pas été accordé, veuillez suivre <a href="${CONST.DENIED_CAMERA_ACCESS_INSTRUCTIONS_URL}">ces instructions</a>.`,
10761073
cameraErrorTitle: 'Erreur de caméra',
10771074
cameraErrorMessage: "Une erreur s'est produite lors de la prise de la photo. Veuillez réessayer.",
10781075
locationAccessTitle: "Autoriser l'accès à la localisation",

src/languages/it.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1056,8 +1056,6 @@ const translations = {
10561056
dragReceiptsAfterEmail: 'o scegli i file da caricare qui sotto.',
10571057
desktopSubtitleSingle: `oppure trascinala qui`,
10581058
desktopSubtitleMultiple: `oppure trascinale qui`,
1059-
chooseReceipt: 'Scegli una ricevuta da caricare o inoltra una ricevuta a',
1060-
chooseReceipts: 'Scegli ricevute da caricare o inoltra ricevute a',
10611059
alternativeMethodsTitle: 'Altri modi per aggiungere ricevute:',
10621060
alternativeMethodsDownloadApp: ({downloadUrl}: {downloadUrl: string}) => `<label-text><a href="${downloadUrl}">Scarica l’app</a> per scansionare dal telefono</label-text>`,
10631061
alternativeMethodsForwardReceipts: ({email}: {email: string}) => `<label-text>Inoltra le ricevute a <a href="mailto:${email}">${email}</a></label-text>`,
@@ -1066,8 +1064,7 @@ const translations = {
10661064
alternativeMethodsTextReceipts: ({phoneNumber}: {phoneNumber: string}) => `<label-text>Invia ricevute via SMS a ${phoneNumber} (solo numeri USA)</label-text>`,
10671065
takePhoto: 'Scatta una foto',
10681066
cameraAccess: "L'accesso alla fotocamera è necessario per scattare foto delle ricevute.",
1069-
deniedCameraAccess: "L'accesso alla fotocamera non è ancora stato concesso, si prega di seguire",
1070-
deniedCameraAccessInstructions: 'queste istruzioni',
1067+
deniedCameraAccess: `L'accesso alla fotocamera non è ancora stato concesso, si prega di seguire <a href="${CONST.DENIED_CAMERA_ACCESS_INSTRUCTIONS_URL}">queste istruzioni</a>.`,
10711068
cameraErrorTitle: 'Errore della fotocamera',
10721069
cameraErrorMessage: 'Si è verificato un errore durante lo scatto della foto. Riprova.',
10731070
locationAccessTitle: "Consenti l'accesso alla posizione",

src/languages/ja.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1058,8 +1058,6 @@ const translations = {
10581058
dragReceiptsAfterEmail: 'または、以下にアップロードするファイルを選択してください。',
10591059
desktopSubtitleSingle: `またはここにドラッグ&ドロップ`,
10601060
desktopSubtitleMultiple: `またはここにドラッグ&ドロップ`,
1061-
chooseReceipt: 'アップロードするレシートを選択するか、レシートを転送してください',
1062-
chooseReceipts: 'アップロードするレシートを選択するか、レシートを転送してください',
10631061
alternativeMethodsTitle: '領収書を追加する別の方法:',
10641062
alternativeMethodsDownloadApp: ({downloadUrl}: {downloadUrl: string}) => `<label-text><a href="${downloadUrl}">アプリをダウンロード</a>して携帯からスキャン</label-text>`,
10651063
alternativeMethodsForwardReceipts: ({email}: {email: string}) => `<label-text>領収書を <a href="mailto:${email}">${email}</a> に転送</label-text>`,
@@ -1068,8 +1066,7 @@ const translations = {
10681066
alternativeMethodsTextReceipts: ({phoneNumber}: {phoneNumber: string}) => `<label-text>領収書を ${phoneNumber} にテキスト送信(米国の番号のみ)</label-text>`,
10691067
takePhoto: '写真を撮る',
10701068
cameraAccess: '領収書の写真を撮るためにカメラへのアクセスが必要です。',
1071-
deniedCameraAccess: 'カメラへのアクセスがまだ許可されていません。以下の手順に従ってください。',
1072-
deniedCameraAccessInstructions: 'これらの手順',
1069+
deniedCameraAccess: `カメラへのアクセスがまだ許可されていません。以下の手順に従ってください。<a href="${CONST.DENIED_CAMERA_ACCESS_INSTRUCTIONS_URL}">これらの手順</a>.`,
10731070
cameraErrorTitle: 'カメラエラー',
10741071
cameraErrorMessage: '写真を撮る際にエラーが発生しました。もう一度お試しください。',
10751072
locationAccessTitle: '位置情報へのアクセスを許可',

src/languages/nl.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1056,8 +1056,6 @@ const translations = {
10561056
dragReceiptsAfterEmail: 'of kies bestanden om hieronder te uploaden.',
10571057
desktopSubtitleSingle: `of sleep het hierheen`,
10581058
desktopSubtitleMultiple: `of sleep ze hierheen`,
1059-
chooseReceipt: 'Kies een bon om te uploaden of stuur een bon door naar',
1060-
chooseReceipts: 'Kies bonnen om te uploaden of stuur bonnen door naar',
10611059
alternativeMethodsTitle: 'Andere manieren om bonnetjes toe te voegen:',
10621060
alternativeMethodsDownloadApp: ({downloadUrl}: {downloadUrl: string}) => `<label-text><a href="${downloadUrl}">Download de app</a> om met je telefoon te scannen</label-text>`,
10631061
alternativeMethodsForwardReceipts: ({email}: {email: string}) => `<label-text>Stuur bonnetjes door naar <a href="mailto:${email}">${email}</a></label-text>`,
@@ -1066,8 +1064,7 @@ const translations = {
10661064
alternativeMethodsTextReceipts: ({phoneNumber}: {phoneNumber: string}) => `<label-text>Sms bonnetjes naar ${phoneNumber} (alleen VS-nummers)</label-text>`,
10671065
takePhoto: 'Maak een foto',
10681066
cameraAccess: "Cameratoegang is vereist om foto's van bonnetjes te maken.",
1069-
deniedCameraAccess: 'Camera-toegang is nog steeds niet verleend, volg alstublieft',
1070-
deniedCameraAccessInstructions: 'deze instructies',
1067+
deniedCameraAccess: `Camera-toegang is nog steeds niet verleend, volg alstublieft <a href="${CONST.DENIED_CAMERA_ACCESS_INSTRUCTIONS_URL}">deze instructies</a>.`,
10711068
cameraErrorTitle: 'Camera fout',
10721069
cameraErrorMessage: 'Er is een fout opgetreden bij het maken van een foto. Probeer het opnieuw.',
10731070
locationAccessTitle: 'Locatietoegang toestaan',

src/languages/pl.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1056,8 +1056,6 @@ const translations = {
10561056
dragReceiptsAfterEmail: 'lub wybierz pliki do przesłania poniżej.',
10571057
desktopSubtitleSingle: `lub przeciągnij i upuść tutaj`,
10581058
desktopSubtitleMultiple: `lub przeciągnij i upuść je tutaj`,
1059-
chooseReceipt: 'Wybierz paragon do przesłania lub prześlij paragon do',
1060-
chooseReceipts: 'Wybierz paragony do przesłania lub prześlij paragony do',
10611059
alternativeMethodsTitle: 'Inne sposoby dodawania paragonów:',
10621060
alternativeMethodsDownloadApp: ({downloadUrl}: {downloadUrl: string}) => `<label-text><a href="${downloadUrl}">Pobierz aplikację</a>, aby skanować z telefonu</label-text>`,
10631061
alternativeMethodsForwardReceipts: ({email}: {email: string}) => `<label-text>Przekazuj paragony na <a href="mailto:${email}">${email}</a></label-text>`,
@@ -1066,8 +1064,7 @@ const translations = {
10661064
alternativeMethodsTextReceipts: ({phoneNumber}: {phoneNumber: string}) => `<label-text>Wysyłaj paragony SMS-em na ${phoneNumber} (tylko numery w USA)</label-text>`,
10671065
takePhoto: 'Zrób zdjęcie',
10681066
cameraAccess: 'Dostęp do aparatu jest wymagany, aby robić zdjęcia paragonów.',
1069-
deniedCameraAccess: 'Dostęp do kamery nadal nie został przyznany, proszę postępować zgodnie z',
1070-
deniedCameraAccessInstructions: 'te instrukcje',
1067+
deniedCameraAccess: `Dostęp do kamery nadal nie został przyznany, proszę postępować zgodnie z <a href="${CONST.DENIED_CAMERA_ACCESS_INSTRUCTIONS_URL}">te instrukcje</a>.`,
10711068
cameraErrorTitle: 'Błąd aparatu',
10721069
cameraErrorMessage: 'Wystąpił błąd podczas robienia zdjęcia. Spróbuj ponownie.',
10731070
locationAccessTitle: 'Zezwól na dostęp do lokalizacji',

src/languages/pt-BR.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1055,8 +1055,6 @@ const translations = {
10551055
uploadMultiple: 'Fazer upload de recibos',
10561056
desktopSubtitleSingle: `ou arraste e solte aqui`,
10571057
desktopSubtitleMultiple: `ou arraste e solte aqui`,
1058-
chooseReceipt: 'Escolha um recibo para enviar ou encaminhe um recibo para',
1059-
chooseReceipts: 'Escolha recibos para enviar ou encaminhe recibos para',
10601058
alternativeMethodsTitle: 'Outras formas de adicionar recibos:',
10611059
alternativeMethodsDownloadApp: ({downloadUrl}: {downloadUrl: string}) => `<label-text><a href="${downloadUrl}">Baixe o app</a> para escanear pelo celular</label-text>`,
10621060
alternativeMethodsForwardReceipts: ({email}: {email: string}) => `<label-text>Encaminhe recibos para <a href="mailto:${email}">${email}</a></label-text>`,
@@ -1065,8 +1063,7 @@ const translations = {
10651063
alternativeMethodsTextReceipts: ({phoneNumber}: {phoneNumber: string}) => `<label-text>Envie recibos por SMS para ${phoneNumber} (apenas números dos EUA)</label-text>`,
10661064
takePhoto: 'Tire uma foto',
10671065
cameraAccess: 'O acesso à câmera é necessário para tirar fotos dos recibos.',
1068-
deniedCameraAccess: 'O acesso à câmera ainda não foi concedido, por favor siga',
1069-
deniedCameraAccessInstructions: 'essas instruções',
1066+
deniedCameraAccess: `O acesso à câmera ainda não foi concedido, por favor siga <a href="${CONST.DENIED_CAMERA_ACCESS_INSTRUCTIONS_URL}">essas instruções</a>.`,
10701067
cameraErrorTitle: 'Erro de câmera',
10711068
cameraErrorMessage: 'Ocorreu um erro ao tirar a foto. Por favor, tente novamente.',
10721069
locationAccessTitle: 'Permitir acesso à localização',

0 commit comments

Comments
 (0)