Suppression proxy_request (décommissionnement TimescaleDB) (#5546)

Author: thbar

apps/transport/lib/db/proxy_request.ex

@@ -30,7 +30,6 @@ defmodule Unlock.Plugs.TokenAuth do
 
     case find_client(Map.get(conn.query_params, "token")) do
       {:ok, token} ->
-        log_request(conn, token)
         conn |> assign(:token, token)
 
       :error ->
@@ -49,19 +48,4 @@ defmodule Unlock.Plugs.TokenAuth do
   end
 
   defp find_client(_), do: {:ok, nil}
-
-  defp log_request(%Plug.Conn{} = conn, %DB.Token{} = token) do
-    if conn.request_path |> String.starts_with?("/resource/") do
-      slug = conn.request_path |> String.trim_leading("/resource/")
-
-      Ecto.Changeset.change(%DB.ProxyRequest{}, %{
-        time: DateTime.utc_now(),
-        token_id: token.id,
-        proxy_id: slug
-      })
-      |> DB.Repo.insert!()
-    end
-  end
-
-  defp log_request(%Plug.Conn{}, nil), do: :ok
 end

apps/transport/lib/unlock/plugs/token_auth.ex

@@ -0,0 +1,12 @@
+defmodule DB.Repo.Migrations.DropProxyRequest do
+  use Ecto.Migration
+
+  # First step of the TimescaleDB removal.
+  def up do
+    drop_if_exists(table(:proxy_request))
+  end
+
+  def down do
+    raise "non-reversible migration: proxy_request hypertable was dropped"
+  end
+end

apps/transport/priv/repo/migrations/20260630120000_drop_proxy_request.exs

@@ -18,7 +18,7 @@ defmodule Unlock.Plugs.TokenAuthTest do
       setup_token_auth_enabled(true)
     end
 
-    test "valid token passed: request is logged" do
+    test "valid token passed: request goes through" do
       slug = "valid-token-logged-#{Ecto.UUID.generate()}"
       %DB.Token{id: token_id} = token = insert_token()
 
@@ -40,10 +40,6 @@ defmodule Unlock.Plugs.TokenAuthTest do
 
       assert resp.resp_body == "somebody-to-love"
       assert %DB.Token{id: ^token_id} = resp.assigns[:token]
-
-      assert [
-               %DB.ProxyRequest{proxy_id: ^slug, token_id: ^token_id}
-             ] = DB.ProxyRequest |> DB.Repo.all()
     end
 
     test "no token passed" do
@@ -67,17 +63,13 @@ defmodule Unlock.Plugs.TokenAuthTest do
 
       assert resp.resp_body == "somebody-to-love"
       assert is_nil(resp.assigns[:token])
-
-      assert [] = DB.ProxyRequest |> DB.Repo.all()
     end
 
     test "invalid token passed" do
       resp = proxy_conn() |> get("/resource/slug?token=invalid")
 
       assert resp.status == 401
       assert resp.resp_body == ~s|{"error":"You must set a valid token in the query parameters"}|
-
-      assert DB.ProxyRequest |> DB.Repo.all() == []
     end
   end
 
@@ -86,30 +78,6 @@ defmodule Unlock.Plugs.TokenAuthTest do
       setup_token_auth_enabled(false)
     end
 
-    test "valid token passed: no requests logged" do
-      slug = "valid-token-not-logged-#{Ecto.UUID.generate()}"
-      token = insert_token()
-
-      setup_proxy_config(%{
-        slug => %Unlock.Config.Item.Generic.HTTP{
-          identifier: slug,
-          target_url: target_url = "http://localhost/some-remote-resource",
-          ttl: 30
-        }
-      })
-
-      Unlock.HTTP.Client.Mock
-      |> expect(:get!, fn url, _headers = [], _options = [] ->
-        assert url == target_url
-        %Unlock.HTTP.Response{body: "somebody-to-love", status: 200, headers: []}
-      end)
-
-      resp = proxy_conn() |> get("/resource/#{slug}?token=#{token.secret}")
-      assert resp.resp_body == "somebody-to-love"
-
-      assert [] = DB.ProxyRequest |> DB.Repo.all()
-    end
-
     test "invalid token passes through without authentication" do
       slug = "invalid-token-passthrough-#{Ecto.UUID.generate()}"
 
@@ -132,8 +100,6 @@ defmodule Unlock.Plugs.TokenAuthTest do
       assert resp.status == 200
       assert resp.resp_body == "somebody-to-love"
       assert is_nil(resp.assigns[:token])
-
-      assert [] = DB.ProxyRequest |> DB.Repo.all()
     end
   end