chore: enable testifylint

Signed-off-by: Matthieu MOREL <[email protected]>

Author: mmorel-35

.golangci.yaml

@@ -10,7 +10,14 @@ linters:
     - govet
     - ineffassign
     - staticcheck
+    - testifylint
     - unused
 linters-settings: # please keep this alphabetized
   goimports:
     local-prefixes: go.etcd.io # Put imports beginning with prefix after 3rd-party packages.
+  testifylint:
+    disable:
+      - go-require
+    enable-all: true
+    formatter:
+      require-f-funcs: true

allocate_test.go

@@ -3,6 +3,9 @@ package bbolt
 import (
 	"testing"
 
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+
 	"go.etcd.io/bbolt/internal/common"
 	"go.etcd.io/bbolt/internal/freelist"
 )
@@ -26,14 +29,11 @@ func TestTx_allocatePageStats(t *testing.T) {
 			prePageCnt := txStats.GetPageCount()
 			allocateCnt := f.FreeCount()
 
-			if _, err := tx.allocate(allocateCnt); err != nil {
-				t.Fatal(err)
-			}
+			_, err := tx.allocate(allocateCnt)
+			require.NoError(t, err)
 
 			txStats = tx.Stats()
-			if txStats.GetPageCount() != prePageCnt+int64(allocateCnt) {
-				t.Errorf("Allocated %d but got %d page in stats", allocateCnt, txStats.GetPageCount())
-			}
+			assert.Equalf(t, txStats.GetPageCount(), prePageCnt+int64(allocateCnt), "Allocated %d but got %d page in stats", allocateCnt, txStats.GetPageCount())
 		})
 	}
 }