Skip to content

Commit 0f89474

Browse files
authored
Merge pull request #19455 from k8s-infra-cherrypick-robot/cherry-pick-19342-to-release-3.6
[release-3.6] Move interface `AlarmBackend` from `server/etcdserver/api/v3alarm` to `server/storage/schema` to fix the `unexported-return` lint error
2 parents fd47d1b + 1fd8887 commit 0f89474

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

server/etcdserver/api/v3alarm/alarms.go

+3-10
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,13 @@ import (
2323
pb "go.etcd.io/etcd/api/v3/etcdserverpb"
2424
"go.etcd.io/etcd/client/pkg/v3/types"
2525
"go.etcd.io/etcd/server/v3/storage/backend"
26+
"go.etcd.io/etcd/server/v3/storage/schema"
2627
)
2728

2829
type BackendGetter interface {
2930
Backend() backend.Backend
3031
}
3132

32-
type AlarmBackend interface {
33-
CreateAlarmBucket()
34-
MustPutAlarm(member *pb.AlarmMember)
35-
MustDeleteAlarm(alarm *pb.AlarmMember)
36-
GetAllAlarms() ([]*pb.AlarmMember, error)
37-
ForceCommit()
38-
}
39-
4033
type alarmSet map[types.ID]*pb.AlarmMember
4134

4235
// AlarmStore persists alarms to the backend.
@@ -45,10 +38,10 @@ type AlarmStore struct {
4538
mu sync.Mutex
4639
types map[pb.AlarmType]alarmSet
4740

48-
be AlarmBackend
41+
be schema.AlarmBackend
4942
}
5043

51-
func NewAlarmStore(lg *zap.Logger, be AlarmBackend) (*AlarmStore, error) {
44+
func NewAlarmStore(lg *zap.Logger, be schema.AlarmBackend) (*AlarmStore, error) {
5245
if lg == nil {
5346
lg = zap.NewNop()
5447
}

server/storage/schema/alarm.go

+9-1
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,20 @@ import (
2121
"go.etcd.io/etcd/server/v3/storage/backend"
2222
)
2323

24+
type AlarmBackend interface {
25+
CreateAlarmBucket()
26+
MustPutAlarm(member *etcdserverpb.AlarmMember)
27+
MustDeleteAlarm(alarm *etcdserverpb.AlarmMember)
28+
GetAllAlarms() ([]*etcdserverpb.AlarmMember, error)
29+
ForceCommit()
30+
}
31+
2432
type alarmBackend struct {
2533
lg *zap.Logger
2634
be backend.Backend
2735
}
2836

29-
func NewAlarmBackend(lg *zap.Logger, be backend.Backend) *alarmBackend {
37+
func NewAlarmBackend(lg *zap.Logger, be backend.Backend) AlarmBackend {
3038
return &alarmBackend{
3139
lg: lg,
3240
be: be,

0 commit comments

Comments
 (0)