Skip to content

Commit a3c072c

Browse files
committed
Add missing error checking after calling DowngradeUpgradeMembers
Signed-off-by: Chun-Hung Tseng <[email protected]> Signed-off-by: Chun-Hung Tseng <[email protected]>
1 parent e25eca2 commit a3c072c

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

tests/e2e/cluster_downgrade_test.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,8 @@ func testDowngradeUpgrade(t *testing.T, clusterSize int, triggerSnapshot bool, t
144144
}
145145

146146
t.Logf("Starting downgrade process to %q", lastVersionStr)
147-
e2e.DowngradeUpgradeMembers(t, nil, epc, len(epc.Procs), currentVersion, lastClusterVersion)
147+
err = e2e.DowngradeUpgradeMembers(t, nil, epc, len(epc.Procs), currentVersion, lastClusterVersion)
148+
require.NoError(t, err)
148149
e2e.AssertProcessLogs(t, leader(t, epc), "the cluster has been downgraded")
149150

150151
t.Log("Downgrade complete")
@@ -170,7 +171,8 @@ func testDowngradeUpgrade(t *testing.T, clusterSize int, triggerSnapshot bool, t
170171
beforeMembers, beforeKV = getMembersAndKeys(t, cc)
171172

172173
t.Logf("Starting upgrade process to %q", currentVersionStr)
173-
e2e.DowngradeUpgradeMembers(t, nil, epc, len(epc.Procs), lastClusterVersion, currentVersion)
174+
err = e2e.DowngradeUpgradeMembers(t, nil, epc, len(epc.Procs), lastClusterVersion, currentVersion)
175+
require.NoError(t, err)
174176
t.Log("Upgrade complete")
175177

176178
afterMembers, afterKV = getMembersAndKeys(t, cc)
@@ -278,7 +280,6 @@ func generateIdenticalVersions(clusterSize int, currentVersion string) []*versio
278280
Server: currentVersion,
279281
Storage: currentVersion,
280282
}
281-
282283
}
283284

284285
return ret

0 commit comments

Comments
 (0)