Execute the same validation for TXN

ArkaSaha30 · ArkaSaha30 · commit b0a3307fdeb0 · 2024-10-05T10:04:57.000+05:30
This commit will ensure all members execute the same validation for TXN by not removing range requests from TXN. Ref patch: ahrtr@76ac23f Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
diff --git a/server/etcdserver/server.go b/server/etcdserver/server.go
@@ -1967,9 +1967,6 @@ func (s *EtcdServer) applyEntryNormal(e *raftpb.Entry, shouldApplyV3 membership.
 
 	needResult := s.w.IsRegistered(id)
 	if needResult || !noSideEffect(&raftReq) {
-		if !needResult && raftReq.Txn != nil {
-			removeNeedlessRangeReqs(raftReq.Txn)
-		}
 		ar = s.applyInternalRaftRequest(&raftReq, shouldApplyV3)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1967,9 +1967,6 @@ func (s EtcdServer) applyEntryNormal(e raftpb.Entry, shouldApplyV3 membership.`
`1967`	`1967`
`1968`	`1968`	`needResult := s.w.IsRegistered(id)`
`1969`	`1969`	`if needResult \|\| !noSideEffect(&raftReq) {`
`1970`		`- if !needResult && raftReq.Txn != nil {`
`1971`		`- removeNeedlessRangeReqs(raftReq.Txn)`
`1972`		`- }`
`1973`	`1970`	`ar = s.applyInternalRaftRequest(&raftReq, shouldApplyV3)`
`1974`	`1971`	`}`
`1975`	`1972`