Skip to content

Commit fb5985d

Browse files
committed
Add review policy
Signed-off-by: Benjamin Wang <[email protected]>
1 parent a029b09 commit fb5985d

File tree

1 file changed

+28
-0
lines changed

1 file changed

+28
-0
lines changed
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
# Review policy
2+
3+
To ensure code quality and shared ownership, this review policy applies to all pull requests (PRs).
4+
5+
## Default rule
6+
7+
PRs should get at least two approvals (/lgtm or GitHub review approval) before merging.
8+
9+
Notes:
10+
- Approvals should come from a maintainer, reviewer, or submodule owner familiar with the relevant code or area.
11+
- If there’s disagreement, maintainers should discuss and agree before merging.
12+
13+
## Exceptions for Less Impactful PRs
14+
15+
For smaller or low-risk changes — such as:
16+
17+
- Tests
18+
- CI workflows
19+
- Documentation
20+
- Comments
21+
22+
The rule can be relaxed:
23+
24+
- One approval is generally enough.
25+
26+
However:
27+
28+
- If the author is a maintainer, they should still get approval from another maintainer, reviewer, or submodule owner, even for minor changes.

0 commit comments

Comments
 (0)