Skip to content

Remove passing of anonymous visualize function #19089

@serathius

Description

@serathius

What would you like to be added?

Before linearizationInfo was a private struct we were not able to return the results up the call stack. So I wrapped the function I needed and passed it like

return result, func(path string) error {
lg.Info("Saving visualization", zap.String("path", path))
err := porcupine.VisualizePath(model.NonDeterministicModel, info, path)
if err != nil {
return fmt.Errorf("failed to visualize, err: %w", err)
}
return nil
}

With https://github.com/etcd-io/etcd/blob/main/tests/robustness/validate/operations.go#L49-L56 making the struct piblic we can simply replace it with passing it linearizationInfo.

Why is this needed?

Cleanup code

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions