Closed
Description
What would you like to be added?
With the Go 1.24 upgrade (#19440), golangci-lint
(specifically the usetesting
linter) started raising many issues related to new test functions available in Go 1.24.
The changes are more or less:
146 files changed, 1157 insertions(+), 1212 deletions(-)
Because we couldn't solve the issues in Go 1.23 (functions don't exist yet), I disabled the linter. The idea is to create small pull requests that address each one of our submodules.
Completion tracking:
- client/pkg: address Go 1.24 usetesting issues #19576
- pkg: address Go 1.24 usetesting issues #19575
- client: address Go 1.24 usetesting issues #19589
- server: address Go 1.24 usetesting issues #19590
- etcdutl: address Go 1.24 usetesting issues #19591
- tests/common: address Go 1.24 usetesting issues #19592
- tests/e2e: address Go 1.24 usetesting issues #19593
- tests/framework: address Go 1.24 usetesting issues #19595
- tests/robustness: address Go 1.24 usetesting issues #19596
- tests/common: address Go 1.24 usetesting issues #20070
-
tests/integration
-
tests/integration/clientv3/concurrency/
- chore(test): address Go usetesting forconcurrency
#20079 -
tests/integration/clientv3/connectivity/
- chore(test): address Go usetesting forconnectivity
#20080 -
tests/integration/clientv3/experimental/
- chore(test): address Go usetesting forexperimental
#20081 -
tests/integration/clientv3/lease/lease_test.go
- chore(test): address usetesting issues inlease_test.go
#20082 -
tests/integration/clientv3/lease/leasing_test.go
- chore(test): address Go usetesting forleasing_test
#20083 -
tests/integration/clientv3/watch_test.go
- chore(test): address Go usetesting forwatch_test
#20084 -
tests/integration/clientv3/*
- chore(test): address Go usetesting forclientV3
#20088 -
tests/integration/v3_auth_test.go
- chore(test): address Go usetesting forv3_auth_test
#20085 -
tests/integration/v3_grpc_test.go
- chore(test): address Go usetesting forv3_grpc_test
#20086 -
tests/integration/v3_lease_test.go
- chore(test): address Go usetesting forv3_lease_test
#20087 -
tests/integration/v3_watch_test.go
- chore(test): address Go usetesting forwatch_test
#20084 -
tests/integration/*
- tests/integration: address usetesting issues #20094
-
- chore(clientV3): address Go usetesting for clientV3 #20095
- chore(test): Re-enable usetesting linter #20089
Why is this needed?
To reenable the linter, and help with code quality.