Skip to content

Commit 220a6d0

Browse files
authored
Merge pull request #12 from etchteam/feature/etch-842-mop-up
Feature/etch 842 mop up
2 parents f4df641 + dac4fbf commit 220a6d0

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

src/components/control/d-tabs.webc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
<style>
22
d-tabs {
3+
position: relative;
4+
z-index: 1; /* Ensure the tabs are on top of the panels */
5+
36
ul {
47
display: flex;
58
flex-wrap: wrap;

src/guide/storybook-example.webc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ date: 2024-10-02
1111

1212
<template webc:type="11ty" 11ty:type="md">
1313

14-
We’ve set up [a Storybook](https://diamond.etch.co/components) to show how Diamond components might look in practice.
14+
We’ve set up <a href="https://diamond.etch.co/components" target="_blank" rel="noopener noreferrer">a Storybook</a> to show how Diamond components might look in practice.
1515

1616
Design system maintainers may want to consider setting up folders like this for each of the four Cs, but it’s an optional step.
1717

src/index.webc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ description: Diamond UI is a methodology for teams who build interfaces.
7070
<h3 class="diamond-text-size-base">Examples</h3>
7171
<ul>
7272
<li>Button &ndash; a clickable component that triggers an action, such as submitting a form</li>
73-
<li>Input &ndash; a hypertext link that takes the user to another page or section of the app</li>
74-
<li>Form &ndash; a form input that allows users to enter information</li>
73+
<li>Link &ndash; a hypertext link that takes the user to another page or section of the app</li>
74+
<li>Input &ndash; a form input that allows users to enter information</li>
7575
</ul>
7676
</diamond-grid-item>
7777
<diamond-grid-item small-mobile="12" small-tablet="6">
@@ -181,7 +181,7 @@ description: Diamond UI is a methodology for teams who build interfaces.
181181
</p>
182182
<ul>
183183
<li>Bloated with props &ndash; <em>too complicated</em></li>
184-
<li>Updated every time a new design ishanded over &ndash; <em>too specific</em></li>
184+
<li>Updated every time a new design is handed over &ndash; <em>too specific</em></li>
185185
<li>Hard to test &ndash; <em>too many variables</em></li>
186186
<li>Awkward to maintain &ndash; <em>too much time</em></li>
187187
<li>Conflicting or impossible prop combinations &ndash; <em>too specific</em></li>

0 commit comments

Comments
 (0)