|
1 | 1 | # ETCswap Connector PR Submission Checklist |
2 | 2 |
|
3 | | -This checklist tracks all requirements for submitting the ETCswap V2 and V3 connector implementation to the official Hummingbot Gateway repository. |
| 3 | +This checklist tracks the status of the ETCswap V2 and V3 connector submission to the official Hummingbot Gateway repository. |
4 | 4 |
|
5 | | -## PR Information |
| 5 | +## PR Status: SUBMITTED |
6 | 6 |
|
7 | | -- **Target Repository:** https://github.com/hummingbot/gateway |
8 | | -- **Target Branch:** `development` |
9 | | -- **Source Branch:** `feat/etcswap-v28-upgrade` (clean PR branch) |
10 | | -- **Connector Name:** ETCswap |
11 | | -- **Networks:** Ethereum Classic (`classic`, Chain ID 61), Mordor Testnet (`mordor`, Chain ID 63) |
12 | | -- **Trading Types:** Router, AMM (V2), CLMM (V3) |
| 7 | +**PR #594:** https://github.com/hummingbot/gateway/pull/594 |
| 8 | + |
| 9 | +| Field | Value | |
| 10 | +|-------|-------| |
| 11 | +| Target Repository | https://github.com/hummingbot/gateway | |
| 12 | +| Target Branch | `main` | |
| 13 | +| Source Branch | `feat/etcswap-connector` | |
| 14 | +| Connector Name | ETCswap | |
| 15 | +| Networks | Ethereum Classic (`classic`, Chain ID 61), Mordor Testnet (`mordor`, Chain ID 63) | |
| 16 | +| Trading Types | Router, AMM (V2), CLMM (V3) | |
| 17 | +| Tests Passing | 134/134 | |
| 18 | +| Submitted | 2026-01-22 | |
13 | 19 |
|
14 | 20 | --- |
15 | 21 |
|
@@ -136,33 +142,31 @@ This checklist tracks all requirements for submitting the ETCswap V2 and V3 conn |
136 | 142 |
|
137 | 143 | --- |
138 | 144 |
|
139 | | -## 5. PR Preparation |
| 145 | +## 5. PR Preparation - COMPLETED |
140 | 146 |
|
141 | 147 | ### 5.1 Branch Setup |
142 | | -- [ ] Fetch latest from upstream: `git fetch upstream` |
143 | | -- [ ] Create clean branch from upstream/development |
144 | | -- [ ] Cherry-pick only connector-related commits (exclude community docs) |
145 | | -- [ ] Resolve any merge conflicts |
| 148 | +- [x] Fetch latest from upstream: `git fetch upstream` |
| 149 | +- [x] Create clean branch from upstream/main: `feat/etcswap-connector` |
| 150 | +- [x] Copy only ETCswap-specific files (no community docs) |
| 151 | +- [x] All 134 tests passing on clean branch |
146 | 152 |
|
147 | 153 | ### 5.2 PR Content |
148 | | -- [ ] Clear PR title: `feat: add ETCswap V2 and V3 connector for Ethereum Classic` |
149 | | -- [ ] PR description includes: |
| 154 | +- [x] Clear PR title: `feat: add ETCswap V2 and V3 connector for Ethereum Classic` |
| 155 | +- [x] PR description includes: |
150 | 156 | - Summary of changes |
151 | 157 | - Networks supported (Classic, Mordor) |
152 | 158 | - Trading types (Router, AMM, CLMM) |
153 | 159 | - Test coverage percentage |
154 | 160 | - Link to contract reference |
155 | | -- [ ] Checklist in PR body per Hummingbot template |
| 161 | +- [x] PR submitted: https://github.com/hummingbot/gateway/pull/594 |
156 | 162 |
|
157 | | -### 5.3 Pre-submission Verification |
| 163 | +### 5.3 Pre-submission Verification - PASSED |
158 | 164 | ```bash |
159 | | -# Run all checks before submitting |
160 | | -pnpm clean && pnpm install |
161 | | -pnpm lint |
162 | | -pnpm typecheck |
163 | | -pnpm build |
164 | | -pnpm test |
165 | | -pnpm test:cov |
| 165 | +# All checks passed on feat/etcswap-connector branch |
| 166 | +pnpm lint # ✓ Passed |
| 167 | +pnpm typecheck # ✓ Passed |
| 168 | +pnpm build # ✓ Passed |
| 169 | +pnpm test # ✓ 134 tests passing |
166 | 170 | ``` |
167 | 171 |
|
168 | 172 | --- |
@@ -241,26 +245,36 @@ gh pr create --base development |
241 | 245 |
|
242 | 246 | | Category | Status | Notes | |
243 | 247 | |----------|--------|-------| |
244 | | -| Code Implementation | Complete | All routes implemented | |
245 | | -| Configuration | Complete | Both networks configured | |
246 | | -| Unit Tests | Partial | Core tests done, need more coverage | |
247 | | -| Integration Tests | Not Started | Requires live RPC testing | |
248 | | -| Code Quality | In Progress | Lint/typecheck need verification | |
249 | | -| Documentation | Complete | Contract reference complete | |
250 | | -| PR Branch | Not Started | Clean branch needed | |
251 | | -| NCP Proposal | Pending | After PR merge | |
| 248 | +| Code Implementation | ✅ Complete | All routes implemented | |
| 249 | +| Configuration | ✅ Complete | Both networks configured | |
| 250 | +| Unit Tests | ✅ Complete | 100 unit tests passing | |
| 251 | +| Live Tests | ✅ Complete | 34 live tests (16 Mordor + 18 Classic) | |
| 252 | +| Code Quality | ✅ Complete | Lint/typecheck/build passing | |
| 253 | +| Documentation | ✅ Complete | Contract reference complete | |
| 254 | +| PR Branch | ✅ Complete | `feat/etcswap-connector` | |
| 255 | +| PR Submitted | ✅ Complete | PR #594 | |
| 256 | +| NCP Proposal | ⏳ Pending | After PR merge | |
| 257 | + |
| 258 | +--- |
| 259 | + |
| 260 | +## Next Steps |
| 261 | + |
| 262 | +1. **PR Review:** Wait for Hummingbot team to review PR #594 |
| 263 | +2. **Address Feedback:** Respond to any review comments |
| 264 | +3. **NCP Proposal:** After merge, submit New Connector Proposal on Snapshot |
| 265 | + - Requires 200,000 HBOT tokens |
| 266 | + - 7-day voting period |
252 | 267 |
|
253 | 268 | --- |
254 | 269 |
|
255 | | -## Contact & Resources |
| 270 | +## Resources |
256 | 271 |
|
| 272 | +- **Upstream PR:** https://github.com/hummingbot/gateway/pull/594 |
257 | 273 | - **ETCswap Website:** https://etcswap.org |
258 | | -- **ETCswap V3 App:** https://v3.etcswap.org |
259 | | -- **ETCswap V2 App:** https://v2.etcswap.org |
260 | 274 | - **ETCswap SDKs:** https://github.com/etcswap/sdks |
261 | 275 | - **Hummingbot Gateway:** https://github.com/hummingbot/gateway |
262 | | -- **Hummingbot Docs:** https://hummingbot.org/gateway/ |
| 276 | +- **NCP Snapshot Space:** https://snapshot.org/#/hbot-ncp.eth |
263 | 277 |
|
264 | 278 | --- |
265 | 279 |
|
266 | | -Last updated: 2025-01-21 |
| 280 | +Last updated: 2026-01-22 |
0 commit comments