using default implementations of trivial constructors

removed the move constructor/assignment from json::value, it was broken on modern compilers
and was also a bit deceiving since it was never cheap to move a json::value, it was
always effectively just a copy. So there was no gain in having it.

Author: eteran

include/cpp-json/array.h

@@ -31,12 +31,12 @@ class array {
 	typedef typename C::size_type               size_type;
 
 public:
-	array();
-	array(array &&other);
-	array(const array &other);
+	array()                            = default;
+	array(array &&other)               = default;
+	array(const array &other)          = default;
+	array &operator=(array &&rhs)      = default;
+	array &operator=(const array &rhs) = default;
 	array(std::initializer_list<value> list);
-	array &operator=(array &&rhs);
-	array &operator=(const array &rhs);
 
 public:
 	iterator begin()                       { return values_.begin();  }

include/cpp-json/array.tcc

@@ -4,26 +4,6 @@
 
 namespace json {
 
-//------------------------------------------------------------------------------
-// Name: array
-//------------------------------------------------------------------------------
-inline array::array() {
-}
-
-//------------------------------------------------------------------------------
-// Name: array
-//------------------------------------------------------------------------------
-inline array::array(const array &other) : values_(other.values_) {
-}
-
-//------------------------------------------------------------------------------
-// Name: array::operator=
-//------------------------------------------------------------------------------
-inline array &array::operator=(const array &rhs) {
-	array(rhs).swap(*this);
-	return *this;
-}
-
 //------------------------------------------------------------------------------
 // Name: array
 //------------------------------------------------------------------------------
@@ -33,22 +13,6 @@ inline array::array(std::initializer_list<value> list) {
 	}
 }
 
-//------------------------------------------------------------------------------
-// Name: array
-//------------------------------------------------------------------------------
-inline array::array(array &&other) : values_(std::move(other.values_)) {
-}
-
-//------------------------------------------------------------------------------
-// Name: operator=
-//------------------------------------------------------------------------------
-inline array &array::operator=(array &&rhs) {
-	if(this != &rhs) {
-		values_ = std::move(rhs.values_);
-	}
-	return *this;
-}
-
 //------------------------------------------------------------------------------
 // Name: append
 //------------------------------------------------------------------------------

include/cpp-json/object.h

@@ -29,12 +29,12 @@ class object {
 	typedef typename C::size_type               size_type;
 
 public:
-	object();
-	object(const object &other);
-	object(object &&other);
+	object()                             = default;
+	object(const object &other)          = default;
+	object(object &&other)               = default;
+	object &operator=(const object &rhs) = default;
+	object &operator=(object &&rhs)      = default;
 	object(std::initializer_list<std::pair<std::string, value>> list);
-	object &operator=(const object &rhs);
-	object &operator=(object &&rhs);
 
 public:
 	iterator begin()              { return values_.begin(); }

include/cpp-json/object.tcc

@@ -4,26 +4,6 @@
 
 namespace json {
 
-//------------------------------------------------------------------------------
-// Name: object
-//------------------------------------------------------------------------------
-inline object::object() {
-}
-
-//------------------------------------------------------------------------------
-// Name: object
-//------------------------------------------------------------------------------
-inline object::object(const object &other) : values_(other.values_) {
-}
-
-//------------------------------------------------------------------------------
-// Name: operator=
-//------------------------------------------------------------------------------
-inline object &object::operator=(const object &rhs) {
-	object(rhs).swap(*this);
-	return *this;
-}
-
 //------------------------------------------------------------------------------
 // Name: object
 //------------------------------------------------------------------------------
@@ -34,22 +14,6 @@ inline object::object(std::initializer_list<std::pair<std::string, value>> list)
 	}
 }
 
-//------------------------------------------------------------------------------
-// Name: object
-//------------------------------------------------------------------------------
-inline object::object(object &&other) : values_(std::move(other.values_)) {
-}
-
-//------------------------------------------------------------------------------
-// Name: operator=
-//------------------------------------------------------------------------------
-inline object &object::operator=(object &&rhs) {
-	if(this != &rhs) {
-		values_ = std::move(rhs.values_);
-	}
-	return *this;
-}
-
 //------------------------------------------------------------------------------
 // Name: insert
 //------------------------------------------------------------------------------

include/cpp-json/value.h

@@ -65,8 +65,6 @@ class value {
 public:
 	value(const value &other);
 	value &operator=(const value &rhs);
-	value(value &&other);
-	value &operator=(value &&rhs);
 
 public:
 	void swap(value &other);

include/cpp-json/value.tcc

@@ -42,23 +42,6 @@ inline value::value(const std::nullptr_t &): type_(type_null) {
 	new (&value_) std::string("null");
 }
 
-//------------------------------------------------------------------------------
-// Name: value
-//------------------------------------------------------------------------------
-inline value::value(value &&other) : value() {
-	other.swap(*this);
-}
-
-//------------------------------------------------------------------------------
-// Name: operator=
-//------------------------------------------------------------------------------
-inline value &value::operator=(value &&rhs) {
-	if(this != &rhs) {
-		value(std::move(rhs)).swap(*this);
-	}
-	return *this;
-}
-
 //------------------------------------------------------------------------------
 // Name: value
 //------------------------------------------------------------------------------
@@ -168,7 +151,7 @@ inline value &value::operator=(const value &rhs) {
 //------------------------------------------------------------------------------
 inline void value::swap(value &other) {
 	using std::swap;
-	
+	  
 	swap(value_, other.value_);
 	swap(type_, other.type_);
 }