fix: reject empty code contract attachment (#2215)

* fix: reject empty code contract attachment

* chore: compile C files for source control

---------

Co-authored-by: BobTheBuidler <bobthebuidlerdefi@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Author: 3 people

brownie/network/contract.py

@@ -334,6 +334,12 @@ def at(
             )
 
         build = self._build
+        # If constructor execution removed the code (e.g. selfdestruct), this
+        # address is not attachable even though the creation tx succeeded.
+        actual_bytecode = web3.eth.get_code(address).hex().removeprefix("0x")
+        if not actual_bytecode:
+            raise ContractNotFound(f"No contract deployed at {address}")
+
         contract = ProjectContract(self._project, build, address, owner, tx)
         if not _verify_deployed_code(address, build["deployedBytecode"], build["language"]):
             # prevent trace attempts when the bytecode doesn't match

build/__native_eth_brownie.c

@@ -57724,7 +57724,7 @@ CPyL3: ;
     CPy_INCREF(cpy_r_val);
     return cpy_r_val;
 CPyL4: ;
-    cpy_r_r1 = CPyStatics[DIFFCHECK_PLACEHOLDER]; /* frozenset({'on', 'True', 'true'}) */
+    cpy_r_r1 = CPyStatics[DIFFCHECK_PLACEHOLDER]; /* frozenset({'True', 'true', 'on'}) */
     CPy_INCREF(cpy_r_val);
     if (likely(PyUnicode_Check(cpy_r_val)))
         cpy_r_r2 = cpy_r_val;
@@ -57744,7 +57744,7 @@ CPyL4: ;
     cpy_r_r6 = 1 ? Py_True : Py_False;
     return cpy_r_r6;
 CPyL8: ;
-    cpy_r_r7 = CPyStatics[DIFFCHECK_PLACEHOLDER]; /* frozenset({'off', 'false', 'False'}) */
+    cpy_r_r7 = CPyStatics[DIFFCHECK_PLACEHOLDER]; /* frozenset({'False', 'off', 'false'}) */
     CPy_INCREF(cpy_r_val);
     if (likely(PyUnicode_Check(cpy_r_val)))
         cpy_r_r8 = cpy_r_val;
@@ -111440,7 +111440,7 @@ CPyL3: ;
     if (!cpy_r_r7) goto CPyL21;
     cpy_r_r8 = CPy_GetExcValue();
     cpy_r_exc = cpy_r_r8;
-    cpy_r_r9 = CPyStatics[DIFFCHECK_PLACEHOLDER]; /* frozenset({'eth_estimateGas', 'eth_call'}) */
+    cpy_r_r9 = CPyStatics[DIFFCHECK_PLACEHOLDER]; /* frozenset({'eth_call', 'eth_estimateGas'}) */
     cpy_r_r10 = PySet_Contains(cpy_r_r9, cpy_r_method);
     cpy_r_r11 = cpy_r_r10 >= 0;
     if (unlikely(!cpy_r_r11)) {
@@ -111556,7 +111556,7 @@ CPyL21: ;
     if (!cpy_r_r32) goto CPyL39;
     cpy_r_r33 = CPy_GetExcValue();
     cpy_r_exc = cpy_r_r33;
-    cpy_r_r34 = CPyStatics[DIFFCHECK_PLACEHOLDER]; /* frozenset({'eth_estimateGas', 'eth_call'}) */
+    cpy_r_r34 = CPyStatics[DIFFCHECK_PLACEHOLDER]; /* frozenset({'eth_call', 'eth_estimateGas'}) */
     cpy_r_r35 = PySet_Contains(cpy_r_r34, cpy_r_method);
     cpy_r_r36 = cpy_r_r35 >= 0;
     if (unlikely(!cpy_r_r36)) {
@@ -111662,7 +111662,7 @@ CPyL41: ;
     if (!cpy_r_r57) goto CPyL54;
     CPy_Unreachable();
 CPyL43: ;
-    cpy_r_r58 = CPyStatics[DIFFCHECK_PLACEHOLDER]; /* frozenset({'eth_estimateGas', 'eth_call'}) */
+    cpy_r_r58 = CPyStatics[DIFFCHECK_PLACEHOLDER]; /* frozenset({'eth_call', 'eth_estimateGas'}) */
     cpy_r_r59 = PySet_Contains(cpy_r_r58, cpy_r_method);
     cpy_r_r60 = cpy_r_r59 >= 0;
     if (unlikely(!cpy_r_r60)) {
@@ -183538,19 +183538,19 @@ CPyL20: ;
     if (!cpy_r_r41) goto CPyL44;
 CPyL21: ;
     cpy_r_r42 = CPySequenceTuple_GetItemUnsafe(cpy_r_r38, cpy_r_r40);
-    if (PyLong_Check(cpy_r_r42))
+    if (PyUnicode_Check(cpy_r_r42))
         cpy_r_r43 = cpy_r_r42;
     else {
         cpy_r_r43 = NULL;
     }
     if (cpy_r_r43 != NULL) goto __LL1100;
-    if (PyUnicode_Check(cpy_r_r42))
+    if (PyLong_Check(cpy_r_r42))
         cpy_r_r43 = cpy_r_r42;
     else {
         cpy_r_r43 = NULL;
     }
     if (cpy_r_r43 != NULL) goto __LL1100;
-    CPy_TypeErrorTraceback("brownie/project/compiler/vyper.py", "_convert_to_semver", 524, CPyStatic_vyper___globals, "union[int, str]", cpy_r_r42);
+    CPy_TypeErrorTraceback("brownie/project/compiler/vyper.py", "_convert_to_semver", 524, CPyStatic_vyper___globals, "union[str, int]", cpy_r_r42);
     goto CPyL45;
 __LL1100: ;
     cpy_r_r44 = PyObject_Str(cpy_r_r43);
@@ -276772,7 +276772,7 @@ const char * const CPyLit_Str[] = {
     "\004\017REQUEST_HEADERS\vNetworkType\rNetworkConfig\017ConfigContainer",
     "\005\022set_active_network\fclear_active\bproperty\016active_network\fnetwork_type",
     "\a\004mode\006Config\nConfigDict\004once\016filterwarnings\bcategory\017parse_variables",
-    "\t\aresolve\002on\004True\003off\005False\aMapping\aTypeVar\boverload\020dotenv.variables",
+    "\t\aresolve\004True\002on\005False\003off\aMapping\aTypeVar\boverload\020dotenv.variables",
     "\006\002_T\r^[-+]\?[0-9]+$\tINT_REGEX\nEthAddress\005Fixed\003Wei",
     "\005\031brownie.convert.datatypes\ato_bool\bto_bytes\nto_decimal\006to_int",
     "\a\tto_string\ato_uint\024brownie.convert.main\a__new__\b__hash__\006__lt__\006__le__",
@@ -276857,7 +276857,7 @@ const char * const CPyLit_Str[] = {
     "\003\021brownie.utils.sql\veth_getCode\016LONGTERM_CACHE",
     "\005#brownie.network.middlewares.caching\ttable_key\003cur\004lock\vloop_thread",
     "\004\tis_killed\nlast_block\017last_block_seen\flast_request",
-    "\004\030RequestCachingMiddleware\fWeb3RPCError\017eth_estimateGas\beth_call",
+    "\004\030RequestCachingMiddleware\fWeb3RPCError\beth_call\017eth_estimateGas",
     "\004\frpc_response\005error\022ContractLogicError\017web3.exceptions",
     "\002+brownie.network.middlewares.catch_tx_revert\031TxRevertCatcherMiddleware",
     "\005\016client_version\nganache/v7\016programCounter\017program_counter\fVM Exception",
@@ -277213,8 +277213,8 @@ const int CPyLit_Tuple[] = {
     1196, 1196, 2, 2464, 2241, 2, 47, 51
 };
 const int CPyLit_FrozenSet[] = {
-    6, 3, 669, 670, 469, 3, 671, 470, 672, 2, 1075, 1076, 2, 1039, 1038,
-    3, 1076, 1039, 1038, 2, 2076, 2077
+    6, 3, 669, 469, 670, 3, 671, 672, 470, 2, 1075, 1076, 2, 1039, 1038,
+    3, 1075, 1039, 1038, 2, 2076, 2077
 };
 CPyModule *CPyModule_brownie____c_constants__internal = NULL;
 CPyModule *CPyModule_brownie____c_constants;